Merge pull request #48863 from shubham1206agra/settlement-button-fix

Fix settlement button

src/components/SettlementButton/index.tsx

@@ -5,7 +5,6 @@ import ButtonWithDropdownMenu from '@components/ButtonWithDropdownMenu';
 import type {PaymentType} from '@components/ButtonWithDropdownMenu/types';
 import * as Expensicons from '@components/Icon/Expensicons';
 import KYCWall from '@components/KYCWall';
-import {useSession} from '@components/OnyxProvider';
 import useLocalize from '@hooks/useLocalize';
 import useNetwork from '@hooks/useNetwork';
 import Navigation from '@libs/Navigation/Navigation';
@@ -61,17 +60,13 @@ function SettlementButton({
 }: SettlementButtonProps) {
  const {translate} = useLocalize();
  const {isOffline} = useNetwork();
- const session = useSession();
  // The app would crash due to subscribing to the entire report collection if chatReportID is an empty string. So we should have a fallback ID here.
  const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID || -1}`);
  const [lastPaymentMethod = '-1'] = useOnyx(ONYXKEYS.NVP_LAST_PAYMENT_METHOD, {selector: (paymentMethod) => paymentMethod?.[policyID]});
  const [policy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`);
  const isInvoiceReport = (!isEmptyObject(iouReport) && ReportUtils.isInvoiceReport(iouReport)) || false;
- const isPaidGroupPolicy = ReportUtils.isPaidGroupPolicyExpenseChat(chatReport);
- const shouldShowPaywithExpensifyOption =
- !isPaidGroupPolicy ||
- (!shouldHidePaymentOptions && ReportUtils.isPayer(session, iouReport) && policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL);
- const shouldShowPayElsewhereOption = (!isPaidGroupPolicy || policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL) && !isInvoiceReport;
+ const shouldShowPaywithExpensifyOption = !shouldHidePaymentOptions && policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL;
+ const shouldShowPayElsewhereOption = !shouldHidePaymentOptions && !isInvoiceReport;
  const paymentButtonOptions = useMemo(() => {
  const buttonOptions = [];
  const isExpenseReport = ReportUtils.isExpenseReport(iouReport);