Merge pull request #38419 from ShridharGoel/patch-2

Expensify · Apr 2, 2024 · 0ca78c3 · 0ca78c3
2 parents 630f1ae + aa15e02
commit 0ca78c3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/components/VideoPlayer/BaseVideoPlayer.js b/src/components/VideoPlayer/BaseVideoPlayer.js
@@ -114,7 +114,7 @@ function BaseVideoPlayer({
  const currentDuration = e.durationMillis || videoDuration * 1000;
  const currentPositon = e.positionMillis || 0;
 
- if (shouldReplayVideo(e, isVideoPlaying, currentDuration, currentPositon)) {
+ if (shouldReplayVideo(e, isPlaying, currentDuration, currentPositon)) {
  videoPlayerRef.current.setStatusAsync({positionMillis: 0, shouldPlay: true});
  }
 
@@ -127,6 +127,7 @@ function BaseVideoPlayer({
  videoStateRef.current = e;
  onPlaybackStatusUpdate(e);
  },
+ // eslint-disable-next-line react-hooks/exhaustive-deps -- we don't want to trigger this when isPlaying changes because isPlaying is only used inside shouldReplayVideo
  [onPlaybackStatusUpdate, preventPausingWhenExitingFullscreen, videoDuration],
  );