Skip to content

Commit

Permalink
Merge pull request #12688 from Expensify/yuwen-removeRenderCell
Browse files Browse the repository at this point in the history
  • Loading branch information
thienlnam authored Nov 11, 2022
2 parents a6977c5 + 40f8927 commit 0d244e4
Showing 1 changed file with 1 addition and 28 deletions.
29 changes: 1 addition & 28 deletions src/pages/home/report/ReportActionsList.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import {View, Animated} from 'react-native';
import {Animated} from 'react-native';
import InvertedFlatList from '../../../components/InvertedFlatList';
import withDrawerState, {withDrawerPropTypes} from '../../../components/withDrawerState';
import compose from '../../../libs/compose';
Expand Down Expand Up @@ -67,7 +67,6 @@ class ReportActionsList extends React.Component {
constructor(props) {
super(props);
this.renderItem = this.renderItem.bind(this);
this.renderCell = this.renderCell.bind(this);
this.keyExtractor = this.keyExtractor.bind(this);

this.state = {
Expand Down Expand Up @@ -146,32 +145,6 @@ class ReportActionsList extends React.Component {
);
}

/**
* This function overrides the CellRendererComponent (defaults to a plain View), giving each ReportActionItem a
* higher z-index than the one below it. This prevents issues where the ReportActionContextMenu overlapping between
* rows is hidden beneath other rows.
*
* @param {Object} cellData
* @param {Object} cellData.item - The ReportAction item in the FlatList.
* @param {Number} cellData.index – The index of the item in the FlatList
* @param {Object|Array} cellData.style – The default styles of the CellRendererComponent provided by the CellRenderer.
* @param {Object} props – All the other Props provided to the CellRendererComponent by default.
* @returns {JSX.Element}
*/
renderCell({
item,
index,
style,
...props
}) {
const cellStyle = [
style,
{zIndex: index},
];
// eslint-disable-next-line react/jsx-props-no-spreading
return <View style={cellStyle} {...props} />;
}

render() {
// Native mobile does not render updates flatlist the changes even though component did update called.
// To notify there something changes we can use extraData prop to flatlist
Expand Down

0 comments on commit 0d244e4

Please sign in to comment.