Merge pull request #14273 from 0xmiroslav/issue-13802

fix long text cut in iOS single line input
Expensify · Jan 13, 2023 · 3661b57 · 3661b57
2 parents f06b625 + 6090150
commit 3661b57
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/components/RNTextInput.js b/src/components/RNTextInput.js
@@ -22,11 +22,6 @@ const RNTextInput = props => (
             }
             props.forwardedRef(ref);
         }}
-
-        // By default, align input to the left to override right alignment in RTL mode which is not yet supported in the App.
-        // eslint-disable-next-line react/jsx-props-no-multi-spaces
-        textAlign="left"
-
         // eslint-disable-next-line
         {...props}
     />

diff --git a/src/components/TextInput/BaseTextInput.js b/src/components/TextInput/BaseTextInput.js
@@ -285,7 +285,10 @@ class BaseTextInput extends Component {
                                             (!hasLabel || this.props.multiline) && styles.pv0,
                                             this.props.prefixCharacter && StyleUtils.getPaddingLeft(this.state.prefixWidth + styles.pl1.paddingLeft),
                                             this.props.secureTextEntry && styles.secureInput,
-                                            !this.props.multiline && {height: this.state.height},
+
+                                            // Explicitly remove `lineHeight` from single line inputs so that long text doesn't disappear
+                                            // once it exceeds the input space (See https://github.com/Expensify/App/issues/13802)
+                                            !this.props.multiline && {height: this.state.height, lineHeight: undefined},
                                         ]}
                                         multiline={this.props.multiline}
                                         maxLength={this.props.maxLength}