Skip to content

Commit

Permalink
Merge pull request #3443 from Expensify/marcaaron-renamePersonalBankA…
Browse files Browse the repository at this point in the history
…ccount

Rename AddBankAccountPage to AddPersonalBankAccountPage
  • Loading branch information
roryabraham authored Jun 8, 2021
2 parents ccdeef7 + 46f4cd0 commit 3683d39
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion src/ROUTES.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {addTrailingForwardSlash} from './libs/Url';
const REPORT = 'r';

export default {
ADD_BANK_ACCOUNT: 'add-bank-account',
ADD_PERSONAL_BANK_ACCOUNT: 'add-personal-bank-account',
HOME: '',
SETTINGS: 'settings',
SETTINGS_PROFILE: 'settings/profile',
Expand Down
4 changes: 2 additions & 2 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ export default {
enterPassword: 'Enter a password',
setPassword: 'Set Password',
},
addBankAccountPage: {
addPersonalBankAccountPage: {
enterPassword: 'Enter password',
addBankAccount: 'Add a Bank Account',
addPersonalBankAccount: 'Add Bank Account',
alreadyAdded: 'This account has already been added.',
selectAccount: 'Select an account:',
},
Expand Down
4 changes: 2 additions & 2 deletions src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,9 @@ export default {
enterPassword: 'Escribe una contraseña',
setPassword: 'Configura tu Contraseña',
},
addBankAccountPage: {
addPersonalBankAccountPage: {
enterPassword: 'Escribe una contraseña',
addBankAccount: 'Agregar una cuenta bancaria',
addPersonalBankAccount: 'Agregar cuenta bancaria',
alreadyAdded: 'Esta cuenta ya ha sido agregada.',
selectAccount: 'Selecciona una cuenta:',
},
Expand Down
6 changes: 3 additions & 3 deletions src/libs/Navigation/AppNavigator/AuthScreens.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import {
NewChatModalStackNavigator,
SettingsModalStackNavigator,
EnablePaymentsStackNavigator,
AddBankAccountModalStackNavigator,
AddPersonalBankAccountModalStackNavigator,
} from './ModalStackNavigators';
import SCREENS from '../../../SCREENS';
import Timers from '../../Timers';
Expand Down Expand Up @@ -266,9 +266,9 @@ class AuthScreens extends React.Component {
component={IOUDetailsModalStackNavigator}
/>
<RootStack.Screen
name="AddBankAccount"
name="AddPersonalBankAccount"
options={modalScreenOptions}
component={AddBankAccountModalStackNavigator}
component={AddPersonalBankAccountModalStackNavigator}
listeners={modalScreenListeners}
/>
</RootStack.Navigator>
Expand Down
10 changes: 5 additions & 5 deletions src/libs/Navigation/AppNavigator/ModalStackNavigators.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import SettingsAddSecondaryLoginPage from '../../../pages/settings/AddSecondaryL
import IOUCurrencySelection from '../../../pages/iou/IOUCurrencySelection';
import ReportParticipantsPage from '../../../pages/ReportParticipantsPage';
import EnablePaymentsPage from '../../../pages/EnablePayments';
import AddBankAccountPage from '../../../pages/AddBankAccountPage';
import AddPersonalBankAccountPage from '../../../pages/AddPersonalBankAccountPage';

const defaultSubRouteOptions = {
cardStyle: styles.navigationScreenCardStyle,
Expand Down Expand Up @@ -147,9 +147,9 @@ const EnablePaymentsStackNavigator = createModalStackNavigator([{
name: 'EnablePayments_Root',
}]);

const AddBankAccountModalStackNavigator = createModalStackNavigator([{
Component: AddBankAccountPage,
name: 'AddBankAccount_Root',
const AddPersonalBankAccountModalStackNavigator = createModalStackNavigator([{
Component: AddPersonalBankAccountPage,
name: 'AddPersonalBankAccount_Root',
}]);

export {
Expand All @@ -163,5 +163,5 @@ export {
NewChatModalStackNavigator,
SettingsModalStackNavigator,
EnablePaymentsStackNavigator,
AddBankAccountModalStackNavigator,
AddPersonalBankAccountModalStackNavigator,
};
4 changes: 2 additions & 2 deletions src/libs/Navigation/linkingConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ export default {
IOU_Details_Root: ROUTES.IOU_DETAILS_WITH_IOU_REPORT_ID,
},
},
AddBankAccount: {
AddPersonalBankAccount: {
screens: {
AddBankAccount_Root: ROUTES.ADD_BANK_ACCOUNT,
AddPersonalBankAccount_Root: ROUTES.ADD_PERSONAL_BANK_ACCOUNT,
},
},
EnablePayments: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const defaultProps = {
},
};

class AddBankAccountPage extends React.Component {
class AddPersonalBankAccountPage extends React.Component {
constructor(props) {
super(props);

Expand Down Expand Up @@ -88,7 +88,7 @@ class AddBankAccountPage extends React.Component {
return (
<ScreenWrapper>
<HeaderWithCloseButton
title={this.props.translate('addBankAccountPage.addBankAccount')}
title={this.props.translate('addPersonalBankAccountPage.addPersonalBankAccount')}
onCloseButtonPress={() => Navigation.dismissModal()}
/>
{(!this.props.plaidLinkToken || this.props.plaidBankAccounts.loading)
Expand All @@ -111,7 +111,7 @@ class AddBankAccountPage extends React.Component {
{accounts.length > 0 && (
<View>
<View style={[styles.m5]}>
<Text>{this.props.translate('addBankAccountPage.selectAccount')}</Text>
<Text>{this.props.translate('addPersonalBankAccountPage.selectAccount')}</Text>
</View>
{_.map(accounts, (account, index) => (
<React.Fragment
Expand All @@ -136,7 +136,7 @@ class AddBankAccountPage extends React.Component {
/>
{account.alreadyExists && (
<Text style={[styles.ml5]}>
{this.props.translate('addBankAccountPage.alreadyAdded')}
{this.props.translate('addPersonalBankAccountPage.alreadyAdded')}
</Text>
)}
</React.Fragment>
Expand All @@ -145,7 +145,7 @@ class AddBankAccountPage extends React.Component {
{!_.isUndefined(this.state.selectedIndex) && (
<>
<Text style={[styles.formLabel]}>
{this.props.translate('addBankAccountPage.enterPassword')}
{this.props.translate('addPersonalBankAccountPage.enterPassword')}
</Text>
<TextInput
secureTextEntry
Expand Down Expand Up @@ -174,8 +174,8 @@ class AddBankAccountPage extends React.Component {
}
}

AddBankAccountPage.propTypes = propTypes;
AddBankAccountPage.defaultProps = defaultProps;
AddPersonalBankAccountPage.propTypes = propTypes;
AddPersonalBankAccountPage.defaultProps = defaultProps;

export default compose(
withLocalize,
Expand All @@ -187,4 +187,4 @@ export default compose(
key: ONYXKEYS.PLAID_BANK_ACCOUNTS,
},
}),
)(AddBankAccountPage);
)(AddPersonalBankAccountPage);

0 comments on commit 3683d39

Please sign in to comment.