-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'Expensify:main' into arrow-feature-signed
- Loading branch information
Showing
142 changed files
with
17,925 additions
and
1,431 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| name: 'Author Checklist Test' | ||
| description: 'Verifies that the author checklist is filled out' | ||
| inputs: | ||
| GITHUB_TOKEN: | ||
| description: Auth token for New Expensify Github | ||
| required: true | ||
| runs: | ||
| using: 'node16' | ||
| main: './index.js' |
69 changes: 69 additions & 0 deletions
69
.github/actions/javascript/authorChecklist/authorChecklist.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| const core = require('@actions/core'); | ||
| const github = require('@actions/github'); | ||
| const https = require('https'); | ||
| const GitHubUtils = require('../../../libs/GithubUtils'); | ||
|
|
||
| const pathToAuthorChecklist = 'https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md'; | ||
| const authorChecklistStartsWith = '### PR Author Checklist'; | ||
| const reviewerChecklistStartsWith = '<summary><h4>PR Reviewer Checklist</h4>'; | ||
| const issue = github.context.payload.issue ? github.context.payload.issue.number : github.context.payload.pull_request.number; | ||
|
|
||
| /** | ||
| * @returns {Promise} | ||
| */ | ||
| function getNumberOfItemsFromAuthorChecklist() { | ||
| return new Promise((resolve, reject) => { | ||
| https.get(pathToAuthorChecklist, (res) => { | ||
| let fileContents = ''; | ||
| res.on('data', (chunk) => { | ||
| fileContents += chunk; | ||
| }); | ||
| res.on('end', () => { | ||
| // Currently, both the author and reviewer checklists are in the PR template file, so we need to do a little bit of parsing the PR description to get just the author | ||
| // checklist. | ||
| const contentAfterStartOfAuthorChecklist = fileContents.split(authorChecklistStartsWith).pop(); | ||
| const contentBeforeStartOfReviewerChecklist = contentAfterStartOfAuthorChecklist.split(reviewerChecklistStartsWith).shift(); | ||
|
|
||
| const numberOfChecklistItems = (contentBeforeStartOfReviewerChecklist.match(/\[ \]/g) || []).length; | ||
| resolve(numberOfChecklistItems); | ||
| }); | ||
| }) | ||
| .on('error', reject); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * @param {Number} numberOfChecklistItems | ||
| */ | ||
| function checkIssueForCompletedChecklist(numberOfChecklistItems) { | ||
| GitHubUtils.getPullRequestBody(issue) | ||
| .then((pullRequestBody) => { | ||
| const contentAfterStartOfAuthorChecklist = pullRequestBody.split(authorChecklistStartsWith).pop(); | ||
| const contentOfAuthorChecklist = contentAfterStartOfAuthorChecklist.split(reviewerChecklistStartsWith).shift(); | ||
|
|
||
| const numberOfFinishedChecklistItems = (contentOfAuthorChecklist.match(/- \[x\]/gi) || []).length; | ||
| const numberOfUnfinishedChecklistItems = (contentOfAuthorChecklist.match(/- \[ \]/g) || []).length; | ||
|
|
||
| const maxCompletedItems = numberOfChecklistItems + 2; | ||
| const minCompletedItems = numberOfChecklistItems - 2; | ||
|
|
||
| console.log(`You completed ${numberOfFinishedChecklistItems} out of ${numberOfChecklistItems} checklist items with ${numberOfUnfinishedChecklistItems} unfinished items`); | ||
|
|
||
| if (numberOfFinishedChecklistItems >= minCompletedItems | ||
| && numberOfFinishedChecklistItems <= maxCompletedItems | ||
| && numberOfUnfinishedChecklistItems === 0) { | ||
| console.log('PR Author checklist is complete 🎉'); | ||
| return; | ||
| } | ||
|
|
||
| console.log(`Make sure you are using the most up to date checklist found here: ${pathToAuthorChecklist}`); | ||
| core.setFailed('PR Author Checklist is not completely filled out. Please check every box to verify you\'ve thought about the item.'); | ||
| }); | ||
| } | ||
|
|
||
| getNumberOfItemsFromAuthorChecklist() | ||
| .then(checkIssueForCompletedChecklist) | ||
| .catch((err) => { | ||
| console.error(err); | ||
| core.setFailed(err); | ||
| }); |
Oops, something went wrong.