Merge pull request #19906 from Expensify/cristi_hookrefactor-Validate…

…LoginPage-index Hook refactor for ValidateLoginPage/index.js
Expensify · Jul 5, 2023 · 7036597 · 7036597
2 parents 75a072a + 2f02364
commit 7036597
Showing 1 changed file with 23 additions and 34 deletions.
diff --git a/src/pages/ValidateLoginPage/index.js b/src/pages/ValidateLoginPage/index.js
@@ -1,4 +1,4 @@
-import React, {Component} from 'react';
+import React, {useEffect} from 'react';
 import PropTypes from 'prop-types';
 import {withOnyx} from 'react-native-onyx';
 import lodashGet from 'lodash/get';
@@ -7,19 +7,14 @@ import * as User from '../../libs/actions/User';
 import FullScreenLoadingIndicator from '../../components/FullscreenLoadingIndicator';
 import ONYXKEYS from '../../ONYXKEYS';
 import * as Session from '../../libs/actions/Session';
-import Permissions from '../../libs/Permissions';
+import usePermissions from '../../hooks/usePermissions';
+import useLocalize from '../../hooks/useLocalize';
 import Navigation from '../../libs/Navigation/Navigation';
-import withLocalize from '../../components/withLocalize';
-import CONST from '../../CONST';
-import compose from '../../libs/compose';
 
 const propTypes = {
     /** The accountID and validateCode are passed via the URL */
     route: validateLinkPropTypes,
 
-    /** List of betas available to current user */
-    betas: PropTypes.arrayOf(PropTypes.string),
-
     /** Session of currently logged in user */
     session: PropTypes.shape({
         /** Currently logged in user authToken */
@@ -31,55 +26,49 @@ const propTypes = {
         /** The email the user logged in with */
         login: PropTypes.string,
     }),
-
-    /** Indicates which locale the user currently has selected */
-    preferredLocale: PropTypes.string,
 };
 
 const defaultProps = {
     route: validateLinkDefaultProps,
-    betas: [],
     session: {
         authToken: null,
     },
     credentials: {},
-    preferredLocale: CONST.LOCALES.DEFAULT,
 };
 
-class ValidateLoginPage extends Component {
-    componentDidMount() {
-        const login = lodashGet(this.props, 'credentials.login', null);
-        const accountID = lodashGet(this.props.route.params, 'accountID', '');
-        const validateCode = lodashGet(this.props.route.params, 'validateCode', '');
+function ValidateLoginPage(props) {
+    const {canUsePasswordlessLogins} = usePermissions();
+    const {preferredLocale} = useLocalize();
+
+    useEffect(() => {
+        const login = lodashGet(props, 'credentials.login', null);
+        const accountID = lodashGet(props.route.params, 'accountID', '');
+        const validateCode = lodashGet(props.route.params, 'validateCode', '');
 
         // A fresh session will not have credentials.login and user permission betas available.
         // In that case, we directly allow users to go through password less flow
-        if (!login || Permissions.canUsePasswordlessLogins(this.props.betas)) {
-            if (lodashGet(this.props, 'session.authToken')) {
+        if (!login || canUsePasswordlessLogins) {
+            if (lodashGet(props, 'session.authToken')) {
                 // If already signed in, do not show the validate code if not on web,
                 // because we don't want to block the user with the interstitial page.
                 Navigation.goBack(false);
             } else {
-                Session.signInWithValidateCodeAndNavigate(accountID, validateCode, this.props.preferredLocale);
+                Session.signInWithValidateCodeAndNavigate(accountID, validateCode, preferredLocale);
             }
         } else {
             User.validateLogin(accountID, validateCode);
         }
-    }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
 
-    render() {
-        return <FullScreenLoadingIndicator />;
-    }
+    return <FullScreenLoadingIndicator />;
 }
 
-ValidateLoginPage.propTypes = propTypes;
 ValidateLoginPage.defaultProps = defaultProps;
+ValidateLoginPage.displayName = 'ValidateLoginPage';
+ValidateLoginPage.propTypes = propTypes;
 
-export default compose(
-    withLocalize,
-    withOnyx({
-        betas: {key: ONYXKEYS.BETAS},
-        credentials: {key: ONYXKEYS.CREDENTIALS},
-        session: {key: ONYXKEYS.SESSION},
-    }),
-)(ValidateLoginPage);
+export default withOnyx({
+    credentials: {key: ONYXKEYS.CREDENTIALS},
+    session: {key: ONYXKEYS.SESSION},
+})(ValidateLoginPage);