Skip to content

Commit

Permalink
Merge pull request #11744 from Expensify/update-staging-from-main
Browse files Browse the repository at this point in the history
Update version to 1.2.13-1 on staging
  • Loading branch information
OSBotify authored Oct 11, 2022
2 parents d5e1c95 + 2c7e1b6 commit 70b7939
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 7 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001021300
versionName "1.2.13-0"
versionCode 1001021301
versionName "1.2.13-1"
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()

if (isNewArchitectureEnabled()) {
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.2.13.0</string>
<string>1.2.13.1</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.2.13.0</string>
<string>1.2.13.1</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.2.13-0",
"version": "1.2.13-1",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
5 changes: 5 additions & 0 deletions src/components/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ const propTypes = {
/** Additional styles to add to checkbox button */
style: stylePropTypes,

/** Callback that is called when mousedown is triggered. */
onMouseDown: PropTypes.func,

/** A ref to forward to the Pressable */
forwardedRef: PropTypes.oneOfType([
PropTypes.func,
Expand All @@ -39,6 +42,7 @@ const defaultProps = {
style: [],
forwardedRef: undefined,
children: null,
onMouseDown: undefined,
};

class Checkbox extends React.Component {
Expand Down Expand Up @@ -85,6 +89,7 @@ class Checkbox extends React.Component {
<Pressable
disabled={this.props.disabled}
onPress={this.firePressHandlerOnClick}
onMouseDown={this.props.onMouseDown}
onFocus={this.onFocus}
onBlur={this.onBlur}
ref={this.props.forwardedRef}
Expand Down
2 changes: 2 additions & 0 deletions src/components/TextInput/BaseTextInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ class BaseTextInput extends Component {
}}
// eslint-disable-next-line
{...inputProps}
autoCorrect={this.props.secureTextEntry ? false : this.props.autoCorrect}
placeholder={placeholder}
placeholderTextColor={themeColors.placeholderText}
underlineColorAndroid="transparent"
Expand Down Expand Up @@ -291,6 +292,7 @@ class BaseTextInput extends Component {
<Checkbox
style={styles.secureInputShowPasswordButton}
onPress={this.togglePasswordVisibility}
onMouseDown={e => e.preventDefault()}
>
<Icon
src={this.state.passwordHidden ? Expensicons.Eye : Expensicons.EyeDisabled}
Expand Down
4 changes: 4 additions & 0 deletions src/components/TextInput/baseTextInputPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const propTypes = {
/** Prefix character */
prefixCharacter: PropTypes.string,

/** Whether autoCorrect functionality should enable */
autoCorrect: PropTypes.bool,

/** Form props */
/** The ID used to uniquely identify the input in a Form */
inputID: PropTypes.string,
Expand All @@ -79,6 +82,7 @@ const defaultProps = {
textInputContainerStyles: [],
inputStyle: [],
autoFocus: false,
autoCorrect: true,

/**
* To be able to function as either controlled or uncontrolled component we should not
Expand Down

0 comments on commit 70b7939

Please sign in to comment.