Merge pull request #17321 from allroundexperts/fix-16521

feat: added descriptive text for tooltips
Expensify · Apr 18, 2023 · 8864416 · 8864416
2 parents 2bacd2b + 5599026
commit 8864416
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 35 deletions.
diff --git a/src/components/MenuItem.js b/src/components/MenuItem.js
@@ -70,7 +70,7 @@ const MenuItem = (props) => {
  const descriptionTextStyle = StyleUtils.combineStyles([
  styles.textLabelSupporting,
  (props.icon ? styles.ml3 : undefined),
- styles.breakWord,
+ styles.breakAll,
  styles.lineHeightNormal,
  props.title ? descriptionVerticalMargin : undefined,
  ]);
@@ -95,6 +95,7 @@ const MenuItem = (props) => {
  props.style,
  StyleUtils.getButtonBackgroundColorStyle(getButtonState(props.focused || hovered, pressed, props.success, props.disabled, props.interactive), true),
  ..._.isArray(props.wrapperStyle) ? props.wrapperStyle : [props.wrapperStyle],
+ styles.popoverMaxWidth,
  ])}
  disabled={props.disabled}
  ref={props.forwardedRef}

diff --git a/src/pages/home/report/ContextMenu/ContextMenuActions.js b/src/pages/home/report/ContextMenu/ContextMenuActions.js
@@ -14,7 +14,6 @@ import CONST from '../../../../CONST';
 import getAttachmentDetails from '../../../../libs/fileDownload/getAttachmentDetails';
 import fileDownload from '../../../../libs/fileDownload';
 import addEncryptedAuthTokenToURL from '../../../../libs/addEncryptedAuthTokenToURL';
-import * as ContextMenuUtils from './ContextMenuUtils';
 import * as Environment from '../../../../libs/Environment/Environment';
 import Permissions from '../../../../libs/Permissions';
 import QuickEmojiReactions from '../../../../components/Reactions/QuickEmojiReactions';
@@ -119,7 +118,7 @@ export default [
  Clipboard.setString(selection);
  hideContextMenu(true, ReportActionComposeFocusManager.focus);
  },
- getDescription: ContextMenuUtils.getPopoverDescription,
+ getDescription: selection => selection,
  },
  {
  textTranslateKey: 'reportActionContextMenu.copyEmailToClipboard',

diff --git a/src/pages/home/report/ContextMenu/ContextMenuUtils/index.js b/src/pages/home/report/ContextMenu/ContextMenuUtils/index.js
diff --git a/src/pages/home/report/ContextMenu/ContextMenuUtils/index.native.js b/src/pages/home/report/ContextMenu/ContextMenuUtils/index.native.js
diff --git a/src/styles/styles.js b/src/styles/styles.js
@@ -3135,6 +3135,10 @@ const styles = {
  width: variables.modalContentMaxWidth,
  textAlign: 'center',
  },
+
+ popoverMaxWidth: {
+ maxWidth: 375,
+ },
 };
 
 export default styles;