Skip to content

Commit

Permalink
Merge pull request #19114 from Expensify/mountiny-cherry-pick-staging…
Browse files Browse the repository at this point in the history
…-18631

🍒 Cherry pick PR #18631 to staging 🍒
  • Loading branch information
OSBotify authored May 17, 2023
2 parents ecb06d7 + 97d0b54 commit 90f4f32
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001031501
versionName "1.3.15-1"
versionCode 1001031502
versionName "1.3.15-2"
}

splits {
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.3.15.1</string>
<string>1.3.15.2</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.3.15.1</string>
<string>1.3.15.2</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.3.15-1",
"version": "1.3.15-2",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
6 changes: 5 additions & 1 deletion src/components/DeeplinkWrapper/index.website.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,14 @@ class DeeplinkWrapper extends PureComponent {
openRouteInDesktopApp(expensifyDeeplinkUrl) {
this.updateAppInstallationCheckStatus();

const browser = Browser.getBrowser();

// This check is necessary for Safari, otherwise, if the user
// does NOT have the Expensify desktop app installed, it's gonna
// show an error in the page saying that the address is invalid
if (CONST.BROWSER.SAFARI === Browser.getBrowser()) {
// It is also necessary for Firefox, otherwise the window.location.href redirect
// will abort the fetch request from NetInfo, which will cause the app to go offline temporarily.
if (browser === CONST.BROWSER.SAFARI || browser === CONST.BROWSER.FIREFOX) {
const iframe = document.createElement('iframe');
iframe.style.display = 'none';
document.body.appendChild(iframe);
Expand Down

0 comments on commit 90f4f32

Please sign in to comment.