Merge pull request #24091 from dukenv0307/fix/22691-regression

[CP Staging] Fix user cannot open detail page of chat room

src/libs/ReportUtils.js

@@ -405,17 +405,6 @@ function isOptimisticPersonalDetail(accountID) {
  return _.isEmpty(allPersonalDetails[accountID]) || !!allPersonalDetails[accountID].isOptimisticPersonalDetail;
 }
 
-/**
- * Check if report is a DM and personal detail of participant is optimistic data
- * @param {String} report
- * @returns {Boolean}
- */
-function shouldDisableDetailPage(report) {
- const participants = lodashGet(report, 'participantAccountIDs', []);
- const isMultipleParticipant = participants.length > 1;
- return !isMultipleParticipant && isOptimisticPersonalDetail(participants[0]) && !report.parentReportID;
-}
-
 /**
  * Checks if a report is a task report from a policy expense chat.
  *
@@ -460,6 +449,25 @@ function isConciergeChatReport(report) {
  return lodashGet(report, 'participantAccountIDs', []).length === 1 && Number(report.participantAccountIDs[0]) === CONST.ACCOUNT_ID.CONCIERGE && !isChatThread(report);
 }
 
+/**
+ * Check if the report is a single chat report that isn't a thread
+ * and personal detail of participant is optimistic data
+ * @param {Object} report
+ * @param {Array} report.participantAccountIDs
+ * @returns {Boolean}
+ */
+function shouldDisableDetailPage(report) {
+ const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []);
+
+ if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) {
+ return false;
+ }
+ if (participantAccountIDs.length === 1) {
+ return isOptimisticPersonalDetail(participantAccountIDs[0]);
+ }
+ return false;
+}
+
 /**
  * Returns true if this report has only one participant and it's an Expensify account.
  * @param {Object} report