Merge pull request #3535 from Expensify/amechler-fix-signout

Fix infinite spinner when signing into an account after signing out

(cherry picked from commit fad0d88)

package.json

@@ -79,7 +79,7 @@
     "react-native-image-picker": "^2.3.3",
     "react-native-keyboard-spacer": "^0.4.1",
     "react-native-modal": "^11.10.0",
-    "react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#52c254fbc4b96224d2ac087e57ef6efc4210ccc1",
+    "react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#1e82e592032c6d0ede8e40f08beb6be790d149e8",
     "react-native-pdf": "^6.2.2",
     "react-native-permissions": "^3.0.1",
     "react-native-picker-select": "8.0.4",

src/libs/actions/Session.js

@@ -58,21 +58,19 @@ function createAccount(login) {
  * Clears the Onyx store and redirects user to the sign in page
  */
 function signOut() {
+    if (credentials && credentials.autoGeneratedLogin) {
+        // Clean up the login that we created
+        API.DeleteLogin({
+            partnerUserID: credentials.autoGeneratedLogin,
+            partnerName: CONFIG.EXPENSIFY.PARTNER_NAME,
+            partnerPassword: CONFIG.EXPENSIFY.PARTNER_PASSWORD,
+            doNotRetry: true,
+        })
+            .catch(error => Onyx.merge(ONYXKEYS.SESSION, {error: error.message}));
+    }
     Timing.clearData();
     redirectToSignIn();
-
     console.debug('Redirecting to Sign In because signOut() was called');
-    if (!credentials || !credentials.autoGeneratedLogin) {
-        return;
-    }
-
-    API.DeleteLogin({
-        partnerUserID: credentials.autoGeneratedLogin,
-        partnerName: CONFIG.EXPENSIFY.PARTNER_NAME,
-        partnerPassword: CONFIG.EXPENSIFY.PARTNER_PASSWORD,
-        doNotRetry: true,
-    })
-        .catch(error => Onyx.merge(ONYXKEYS.SESSION, {error: error.message}));
 }
 
 /**