Merge pull request #16816 from Expensify/neil-split-crash

Prevent a bill split crash when a report has an undefined participant
Expensify · Mar 31, 2023 · b6f7eca · b6f7eca
2 parents bbcf7ce + 6a874bc
commit b6f7eca
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/src/libs/OptionsListUtils.js b/src/libs/OptionsListUtils.js
@@ -103,22 +103,26 @@ function getPersonalDetailsForLogins(logins, personalDetails) {
     if (!personalDetails) {
         return personalDetailsForLogins;
     }
-    _.each(logins, (login) => {
-        let personalDetail = personalDetails[login];
-        if (!personalDetail) {
-            personalDetail = {
-                login,
-                displayName: Str.removeSMSDomain(login),
-                avatar: ReportUtils.getDefaultAvatar(login),
-            };
-        }
+    _.chain(logins)
+
+        // Somehow it's possible for the logins coming from report.participants to contain undefined values so we use compact to remove them.
+        .compact()
+        .each((login) => {
+            let personalDetail = personalDetails[login];
+            if (!personalDetail) {
+                personalDetail = {
+                    login,
+                    displayName: Str.removeSMSDomain(login),
+                    avatar: ReportUtils.getDefaultAvatar(login),
+                };
+            }
 
-        if (login === CONST.EMAIL.CONCIERGE) {
-            personalDetail.avatar = CONST.CONCIERGE_ICON_URL;
-        }
+            if (login === CONST.EMAIL.CONCIERGE) {
+                personalDetail.avatar = CONST.CONCIERGE_ICON_URL;
+            }
 
-        personalDetailsForLogins[login] = personalDetail;
-    });
+            personalDetailsForLogins[login] = personalDetail;
+        });
     return personalDetailsForLogins;
 }
 

diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js
@@ -89,7 +89,13 @@ function getChatType(report) {
  * @returns {string}
  */
 function getReportParticipantsTitle(logins) {
-    return _.map(logins, login => Str.removeSMSDomain(login)).join(', ');
+    return _.chain(logins)
+
+        // Somehow it's possible for the logins coming from report.participants to contain undefined values so we use compact to remove them.
+        .compact()
+        .map(login => Str.removeSMSDomain(login))
+        .value()
+        .join(', ');
 }
 
 /**