pass boolean always instead of optional prop

Expensify · May 14, 2023 · b715025 · b715025
1 parent d5aee38
commit b715025
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/components/OpacityView.js b/src/components/OpacityView.js
@@ -9,7 +9,7 @@ const propTypes = {
     /**
      * Should we dim the view
      */
-    shouldDim: PropTypes.bool,
+    shouldDim: PropTypes.bool.isRequired,
 
     /**
      * Content to render
@@ -31,7 +31,6 @@ const propTypes = {
 };
 
 const defaultProps = {
-    shouldDim: false,
     style: [],
     dimmingValue: variables.hoverDimValue,
 };

diff --git a/src/components/Pressable/PressableWithFeedback.js b/src/components/Pressable/PressableWithFeedback.js
@@ -54,7 +54,7 @@ const PressableWithFeedback = forwardRef((props, ref) => {
         >
             {(state) => (
                 <OpacityView
-                    shouldDim={!disabled && (state.pressed || state.hovered)}
+                    shouldDim={Boolean(!disabled && (state.pressed || state.hovered))}
                     dimmingValue={state.pressed ? props.pressDimmingValue : props.hoverDimmingValue}
                     style={[
                         ...StyleUtils.parseStyleFromFunction(props.style, state),