Merge pull request #27795 from software-mansion-labs/ts-migration/Mov…

…eToIndexedDB [No QA][TS migration] Migrate 'MoveToIndexedDB.js' lib to TypeScript
Expensify · Sep 21, 2023 · bb32cc5 · bb32cc5
2 parents ee023d8 + d79af66
commit bb32cc5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 153 deletions.
diff --git a/src/libs/migrateOnyx.js b/src/libs/migrateOnyx.js
@@ -2,7 +2,6 @@ import _ from 'underscore';
 import Log from './Log';
 import AddEncryptedAuthToken from './migrations/AddEncryptedAuthToken';
 import RenamePriorityModeKey from './migrations/RenamePriorityModeKey';
-import MoveToIndexedDB from './migrations/MoveToIndexedDB';
 import RenameExpensifyNewsStatus from './migrations/RenameExpensifyNewsStatus';
 import AddLastVisibleActionCreated from './migrations/AddLastVisibleActionCreated';
 import PersonalDetailsByAccountID from './migrations/PersonalDetailsByAccountID';
@@ -14,15 +13,7 @@ export default function () {
 
     return new Promise((resolve) => {
         // Add all migrations to an array so they are executed in order
-        const migrationPromises = [
-            MoveToIndexedDB,
-            RenamePriorityModeKey,
-            AddEncryptedAuthToken,
-            RenameExpensifyNewsStatus,
-            AddLastVisibleActionCreated,
-            PersonalDetailsByAccountID,
-            RenameReceiptFilename,
-        ];
+        const migrationPromises = [RenamePriorityModeKey, AddEncryptedAuthToken, RenameExpensifyNewsStatus, AddLastVisibleActionCreated, PersonalDetailsByAccountID, RenameReceiptFilename];
 
         // Reduce all promises down to a single promise. All promises run in a linear fashion, waiting for the
         // previous promise to finish before moving onto the next one.

diff --git a/src/libs/migrations/MoveToIndexedDB.js b/src/libs/migrations/MoveToIndexedDB.js
diff --git a/tests/unit/MigrationTest.js b/tests/unit/MigrationTest.js
@@ -1,11 +1,8 @@
 import Onyx from 'react-native-onyx';
 import _ from 'underscore';
 import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
-import CONST from '../../src/CONST';
 import Log from '../../src/libs/Log';
-import getPlatform from '../../src/libs/getPlatform';
 import AddLastVisibleActionCreated from '../../src/libs/migrations/AddLastVisibleActionCreated';
-import MoveToIndexedDB from '../../src/libs/migrations/MoveToIndexedDB';
 import PersonalDetailsByAccountID from '../../src/libs/migrations/PersonalDetailsByAccountID';
 import CheckForPreviousReportActionID from '../../src/libs/migrations/CheckForPreviousReportActionID';
 import ONYXKEYS from '../../src/ONYXKEYS';
@@ -28,71 +25,6 @@ describe('Migrations', () => {
         return waitForBatchedUpdates();
     });
 
-    describe('MoveToIndexedDb', () => {
-        let mockMultiSet;
-        beforeEach(() => {
-            getPlatform.mockImplementation(() => CONST.PLATFORM.WEB);
-            mockMultiSet = jest.spyOn(Onyx, 'multiSet').mockImplementation(() => Promise.resolve());
-            localStorage.clear();
-        });
-
-        afterAll(() => {
-            mockMultiSet.mockRestore(Onyx, 'multiSet');
-            localStorage.clear();
-        });
-
-        it('Should do nothing for non web/desktop platforms', () => {
-            // Given the migration is not running on web or desktop
-            getPlatform.mockImplementation(() => CONST.PLATFORM.ANDROID);
-
-            // When the migration runs
-            return MoveToIndexedDB().then(() => {
-                // Then we don't expect any storage calls
-                expect(Onyx.multiSet).not.toHaveBeenCalled();
-            });
-        });
-
-        it('Should do nothing when there is no old session data', () => {
-            // Given no session in old storage medium (localStorage)
-            localStorage.removeItem(ONYXKEYS.SESSION);
-
-            // When the migration runs
-            return MoveToIndexedDB().then(() => {
-                // Then we don't expect any storage calls
-                expect(Onyx.multiSet).not.toHaveBeenCalled();
-            });
-        });
-
-        it('Should migrate Onyx keys in localStorage to (new) Onyx', () => {
-            // Given some old data exists in storage
-            const data = {
-                [ONYXKEYS.SESSION]: {authToken: 'mock-token', loading: false},
-                [ONYXKEYS.ACCOUNT]: {email: 'test@mock.com'},
-                [ONYXKEYS.NETWORK]: {isOffline: true},
-            };
-
-            _.forEach(data, (value, key) => localStorage.setItem(key, JSON.stringify(value)));
-
-            // When the migration runs
-            return MoveToIndexedDB().then(() => {
-                // Then multiset should be called with all the data available in localStorage
-                expect(Onyx.multiSet).toHaveBeenCalledWith(data);
-            });
-        });
-
-        it('Should not clear non Onyx keys from localStorage', () => {
-            // Given some Onyx and non-Onyx data exists in localStorage
-            localStorage.setItem(ONYXKEYS.SESSION, JSON.stringify({authToken: 'mock-token'}));
-            localStorage.setItem('non-onyx-item', 'MOCK');
-
-            // When the migration runs
-            return MoveToIndexedDB().then(() => {
-                // Then non-Onyx data should remain in localStorage
-                expect(localStorage.getItem('non-onyx-item')).toEqual('MOCK');
-            });
-        });
-    });
-
     describe('AddLastVisibleActionCreated', () => {
         it('Should add lastVisibleActionCreated wherever lastActionCreated currently is', () =>
             Onyx.multiSet({