-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #39347 from tienifr/fix/38905
fix unsubscribe is typing event if not focus on screen
- Loading branch information
Showing
3 changed files
with
81 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import type {RouteProp} from '@react-navigation/native'; | ||
| import {useIsFocused, useRoute} from '@react-navigation/native'; | ||
| import {useEffect, useRef} from 'react'; | ||
| import {InteractionManager} from 'react-native'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
| import Navigation from '@libs/Navigation/Navigation'; | ||
| import type {CentralPaneNavigatorParamList} from '@libs/Navigation/types'; | ||
| import * as Report from '@userActions/Report'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type SCREENS from '@src/SCREENS'; | ||
| import type * as OnyxTypes from '@src/types/onyx'; | ||
|
|
||
| type UserTypingEventListenerOnyxProps = { | ||
| /** Stores last visited path */ | ||
| lastVisitedPath?: string; | ||
| }; | ||
|
|
||
| type UserTypingEventListenerProps = UserTypingEventListenerOnyxProps & { | ||
| /** The report currently being looked at */ | ||
| report: OnyxTypes.Report; | ||
| }; | ||
| function UserTypingEventListener({report, lastVisitedPath}: UserTypingEventListenerProps) { | ||
| const didSubscribeToReportTypingEvents = useRef(false); | ||
| const reportID = report.reportID; | ||
| const isFocused = useIsFocused(); | ||
| const route = useRoute<RouteProp<CentralPaneNavigatorParamList, typeof SCREENS.REPORT>>(); | ||
| useEffect(() => { | ||
| // Ensures any optimistic report that is being created (ex: a thread report) gets created and initialized successfully before subscribing | ||
| if (route?.params?.reportID !== reportID) { | ||
| return; | ||
| } | ||
| let interactionTask: ReturnType<typeof InteractionManager.runAfterInteractions> | null = null; | ||
| if (isFocused) { | ||
| // Ensures subscription event succeeds when the report/workspace room is created optimistically. | ||
| // Check if the optimistic `OpenReport` or `AddWorkspaceRoom` has succeeded by confirming | ||
| // any `pendingFields.createChat` or `pendingFields.addWorkspaceRoom` fields are set to null. | ||
| // Existing reports created will have empty fields for `pendingFields`. | ||
| const didCreateReportSuccessfully = !report.pendingFields || (!report.pendingFields.addWorkspaceRoom && !report.pendingFields.createChat); | ||
|
|
||
| if (!didSubscribeToReportTypingEvents.current && didCreateReportSuccessfully) { | ||
| interactionTask = InteractionManager.runAfterInteractions(() => { | ||
| Report.subscribeToReportTypingEvents(reportID); | ||
| didSubscribeToReportTypingEvents.current = true; | ||
| }); | ||
| } | ||
| } else { | ||
| const topmostReportId = Navigation.getTopmostReportId(); | ||
|
|
||
| if (topmostReportId !== reportID && didSubscribeToReportTypingEvents.current) { | ||
| didSubscribeToReportTypingEvents.current = false; | ||
| InteractionManager.runAfterInteractions(() => { | ||
| Report.unsubscribeFromReportChannel(reportID); | ||
| }); | ||
| } | ||
| } | ||
| return () => { | ||
| if (!interactionTask) { | ||
| return; | ||
| } | ||
| interactionTask.cancel(); | ||
| }; | ||
| }, [isFocused, report.pendingFields, didSubscribeToReportTypingEvents, lastVisitedPath, reportID, route]); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| UserTypingEventListener.displayName = 'UserTypingEventListener'; | ||
|
|
||
| export default withOnyx<UserTypingEventListenerProps, UserTypingEventListenerOnyxProps>({ | ||
| lastVisitedPath: { | ||
| key: ONYXKEYS.LAST_VISITED_PATH, | ||
| selector: (path) => path ?? '', | ||
| }, | ||
| })(UserTypingEventListener); |