Merge pull request #41292 from tienifr/fix/40205

fix: shorthand mention in backtick
Expensify · May 13, 2024 · f443efa · f443efa
2 parents 59e74e9 + 0ae4db1
commit f443efa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -1954,7 +1954,7 @@ const CONST = {
 
  POLICY_ID_FROM_PATH: /\/w\/([a-zA-Z0-9]+)(\/|$)/,
 
- SHORT_MENTION: new RegExp(`@[\\w\\-\\+\\'#@]+(?:\\.[\\w\\-\\'\\+]+)*`, 'gim'),
+ SHORT_MENTION: new RegExp(`@[\\w\\-\\+\\'#@]+(?:\\.[\\w\\-\\'\\+]+)*(?![^\`]*\`)`, 'gim'),
  },
 
  PRONOUNS: {

diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
@@ -3361,6 +3361,9 @@ function getParsedComment(text: string, parsingDetails?: ParsingDetails): string
 
  const parser = new ExpensiMark();
  const textWithMention = text.replace(CONST.REGEX.SHORT_MENTION, (match) => {
+ if (!Str.isValidMention(match)) {
+ return match;
+ }
  const mention = match.substring(1);
  const mentionWithDomain = addDomainToShortMention(mention);
  return mentionWithDomain ? `@${mentionWithDomain}` : match;