Merge branch 'main' into workspacenames_validation_23376_signed

.eslintrc.js

@@ -163,5 +163,13 @@ module.exports = {
  ],
  },
  },
+ {
+ files: ['tests/**/*.{js,jsx,ts,tsx}', '.github/**/*.{js,jsx,ts,tsx}'],
+ rules: {
+ '@lwc/lwc/no-async-await': 'off',
+ 'no-await-in-loop': 'off',
+ 'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
+ },
+ },
  ],
 };

.github/ISSUE_TEMPLATE/DesignDoc.md

@@ -27,6 +27,7 @@ labels: Daily, NewFeature
 - [ ] Confirm that the doc has the minimum necessary number of reviews before proceeding
 - [ ] Email `strategy@expensify.com` one last time to let them know the Design Doc is moving into the implementation phase
 - [ ] Implement the changes
+- [ ] Add regression tests so that QA can test your feature with every deploy ([instructions](https://stackoverflowteams.com/c/expensify/questions/363))
 - [ ] Send out a follow up email to `strategy@expensify.com` once everything has been implemented and do a **Project Wrap-Up** retrospective that provides:
  - Summary of what we accomplished with this project
  - What went well?

.github/actions/composite/setupNode/action.yml

@@ -16,38 +16,13 @@ runs:
  uses: actions/cache@v3
  with:
  path: node_modules
- key: ${{ runner.os }}-node-modules-${{ hashFiles('package-lock.json') }}
+ key: ${{ runner.os }}-node-modules-${{ hashFiles('package-lock.json', 'patches/**') }}
 
  - id: cache-desktop-node-modules
  uses: actions/cache@v3
  with:
  path: desktop/node_modules
- key: ${{ runner.os }}-desktop-node-modules-${{ hashFiles('desktop/package-lock.json') }}
-
- - name: Check if patch files changed
- id: patchCheck
- shell: bash
- run: |
- set -e
- if [[ `git diff main --name-only | grep \.patch` != null ]]; then 
- echo 'CHANGES_IN_PATCH_FILES=true' >> "$GITHUB_OUTPUT"
- else 
- echo 'CHANGES_IN_PATCH_FILES=false' >> "$GITHUB_OUTPUT"
- fi
-
- - name: Patch root project node packages
- shell: bash
- if: | 
- steps.patchCheck.outputs.CHANGES_IN_PATCH_FILES == 'true' && 
- steps.cache-node-modules.outputs.cache-hit == 'true'
- run: npx patch-package
-
- - name: Patch node packages for desktop submodule
- shell: bash
- if: | 
- steps.patchCheck.outputs.CHANGES_IN_PATCH_FILES == 'true' && 
- steps.cache-desktop-node-modules.outputs.cache-hit == 'true'
- run: cd desktop && npx patch-package
+ key: ${{ runner.os }}-desktop-node-modules-${{ hashFiles('desktop/package-lock.json', 'desktop/patches/**') }}
 
  - name: Install root project node packages
  if: steps.cache-node-modules.outputs.cache-hit != 'true'