fix: just warn whjen app couldn't be installed

Signed-off-by: Hanno J. Gödecke <die.drei99@yahoo.de>
Expensify · Oct 14, 2022 · f64cab1 · f64cab1
1 parent a65387c
commit f64cab1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/e2e/utils/installApp.js b/e2e/utils/installApp.js
@@ -1,5 +1,6 @@
 const {APP_PACKAGE} = require('../config');
 const execAsync = require('./execAsync');
+const Logger = require('./Logger');
 
 const APP_PATH_FROM_ROOT = 'android/app/build/outputs/apk/e2eRelease/app-e2eRelease.apk';
 
@@ -15,5 +16,8 @@ module.exports = function (platform = 'android') {
     }
 
     // Uninstall first, then install
-    return execAsync(`adb uninstall ${APP_PACKAGE}`).finally(() => execAsync(`adb install ${APP_PATH_FROM_ROOT}`));
+    return execAsync(`adb uninstall ${APP_PACKAGE}`).catch((e) => {
+        // Ignore errors
+        Logger.warn('Failed to uninstall app:', e);
+    }).finally(() => execAsync(`adb install ${APP_PATH_FROM_ROOT}`));
 };
diff --git a/e2e/utils/logger.js b/e2e/utils/logger.js
@@ -66,7 +66,7 @@ const info = (...args) => {
 };
 
 const warn = (...args) => {
-    const lines = [`${COLOR_YELLOW}⚠️`, ...args, `${COLOR_RESET}`];
+    const lines = [`\n${COLOR_YELLOW}⚠️`, ...args, `${COLOR_RESET}\n`];
     console.debug(...lines);
     log(...lines);
 };