Merge pull request #47364 from FitseTLT/fix-displaying-disabled-tag-i…

…n-money-request-view Fix - Disabled "Region" not shown in confirmation page but displayed in money request view
Expensify · Aug 26, 2024 · f7c9fa8 · f7c9fa8
2 parents 279f302 + 0866f7c
commit f7c9fa8
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/components/ReportActionItem/MoneyRequestView.tsx b/src/components/ReportActionItem/MoneyRequestView.tsx
@@ -410,15 +410,21 @@ function MoneyRequestView({
  ...parentReportAction?.errors,
  };
 
- const tagList = policyTagLists.map(({name, orderWeight}, index) => {
+ const tagList = policyTagLists.map(({name, orderWeight, tags}, index) => {
+ const tagForDisplay = TransactionUtils.getTagForDisplay(updatedTransaction ?? transaction, index);
+ const shouldShow = !!tagForDisplay || OptionsListUtils.hasEnabledOptions(tags);
+ if (!shouldShow) {
+ return null;
+ }
+
  const tagError = getErrorForField(
  'tag',
  {
  tagListIndex: index,
  tagListName: name,
  },
  PolicyUtils.hasDependentTags(policy, policyTagList),
- TransactionUtils.getTagForDisplay(updatedTransaction ?? transaction, index),
+ tagForDisplay,
  );
  return (
  <OfflineWithFeedback
@@ -427,7 +433,7 @@ function MoneyRequestView({
  >
  <MenuItemWithTopDescription
  description={name ?? translate('common.tag')}
- title={TransactionUtils.getTagForDisplay(updatedTransaction ?? transaction, index)}
+ title={tagForDisplay}
  interactive={canEdit}
  shouldShowRightIcon={canEdit}
  titleStyle={styles.flex1}