[HOLD for payment 2022-08-11] [$250] Web - LHN - The wrong chat opens after resizing

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Resize the window to a smaller view
4. Chat with any user and go back
5. Select one of the options (search, new group, request or send money) and press ESC

Expected Result:

User is returned to LHN

Actual Result:

User is returned to previously opened chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.1.86-0

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers): Any

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5662844_Recording__1266.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

I think this can be worked on externally.

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[puneetlath]

External upwork job: https://www.upwork.com/jobs/~01abd25790afa78577
Internal upwork job: https://www.upwork.com/ab/applicants/1552030017614761984/job-details

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[syedsaroshfarrukhdot]

Proposal

App/src/libs/Navigation/AppNavigator/BaseDrawerNavigator.js

Line 44 in 151ec1a

this.state = {

App/src/libs/Navigation/AppNavigator/BaseDrawerNavigator.js

Line 48 in 151ec1a

defaultStatus: Navigation.getDefaultDrawerState(props.isSmallScreenWidth),

The problem is the defaultStatus was set in intial state but was never updated when screen resizes to width of isSmallScreenWidth which leads to the drawer close everytime

Solution
We need to add componentDidUpdate and update defaultStatus on screen rezise to width of isSmallScreenWidth

componentDidUpdate(prevProps) {
// You don't have to do this check first, but it can help prevent an unneeded render
if (prevProps !== this.props) {
this.setState({
defaultStatus: Navigation.getDefaultDrawerState(
prevProps.isSmallScreenWidth,
),
});
}
}

After Fixing

181161187-304e6496-0fa4-4aa5-9e54-23ab48254a12.1.mov

[rushatgabhane]

@syedsaroshfarrukhdot the expected result is that the user is returned to LHN (Left hand navigator / page with all the chats)

But your proposal returns to a previously opened chat

[syedsaroshfarrukhdot]

@syedsaroshfarrukhdot the expected result is that the user is returned to LHN (Left hand navigator / page with all the chats)

But your proposal returns to a previously opened chat

@rushatgabhane I Have Added Both Before And After Video Somehow After Solution Video Preview Is Not Working On First Comment So Adding It Again Here. It Is Returning To LHN With All Chats On Keyboard Esc Press.

181161187-304e6496-0fa4-4aa5-9e54-23ab48254a12.1.mov

[rushatgabhane]

Oh, haha!
@syedsaroshfarrukhdot's proposal looks good! (please make sure to follow the style guide)

@Julesssss C+ reviewed 🎀 👀 🎀

[melvin-bot]

📣 @syedsaroshfarrukhdot You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[syedsaroshfarrukhdot]

I have applied to the job in upwork hopefully the PR will be ready for review by tommorow (29th July 2022). I will be posting on GitHub issue once PR is ready.

[Julesssss]

Thanks @syedsaroshfarrukhdot, sounds good!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.87-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixing Previous Chat Open On Escape Press #10152

If no regressions arise, payment will be issued on 2022-08-11. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[puneetlath]

Paid @syedsaroshfarrukhdot.

Sent contract to @rushatgabhane for C+.

[rushatgabhane]

accepted!

[puneetlath]

Everyone has been paid. Thanks everyone!