-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [$250] IOS - Profile - Uploaded picture have been rotated itself after saving. #10258
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @Justicea83 ( |
this can be external |
@tabakharniuk Any thoughts? |
@parasharrajat checking |
Triggered auto assignment to @JmillsExpensify ( |
@Justicea83 if you want, I can self assign and export this right now since it's |
@michaelhaxhiu , I've assigned you |
Job exported - https://www.upwork.com/jobs/~01ed586ed99411249a |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Triggered auto assignment to @Beamanator ( |
Triggered auto assignment to @rafecolton ( |
@rafecolton would you please create a Fork of https://github.com/oguzhnatly/react-native-image-manipulator? Here's a handy SO: https://stackoverflow.com/c/expensify/questions/10007/10008#10008 (looks like you wrote it 😆 ) |
Done! |
Thanks @rafecolton ! Ok @tabakharniuk would you mind making a PR on that new repo (https://github.com/Expensify/react-native-image-manipulator) with your changes? |
Done ✅ |
Thanks @tabakharniuk ! PR in the react-native-image-manipulator repo merged 👍 now can you make a PR in E/App with the updated package link? You can see how we currently do this in |
Done ✅ cc: @Beamanator |
Thanks @tabakharniuk ! I'll wait for @Santhosh-Sellavel to review first 👍 |
Fix merged! |
Issue not reproducible during KI retests. (First week) |
Not overdue, fix is on staging |
Hmm shouldn't this have made it to prod by now? |
Yeah, It's on production, verified everything looks good! This should be due for payment. cc: @michaelhaxhiu |
Made a new job post (last one expired), and invited @Santhosh-Sellavel and @tabakharniuk. Respond here after you accept and I can disperse payment |
Done! |
@tabakharniuk is paid, just waiting for santhosh to accept so I can pay & close this GH |
Bump @Santhosh-Sellavel |
Actually, bump for me! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Uploaded picture have been not rotated itself after saving
Actual Result:
Uploaded picture have been rotated itself after saving
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.88.1
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5676828_Image_from_iOS__44_.mp4
Issue reported by: Applause - Internal Team
Upwork job link : https://www.upwork.com/jobs/~0169e2129c15b874c0
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: