Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [$250] IOS - Profile - Uploaded picture have been rotated itself after saving. #10258

Closed
kbecciv opened this issue Aug 5, 2022 · 58 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Aug 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Go Setting - tap on Avatar
  4. Select upload photo
  5. Tap choose from gallery
  6. Pick any picture and tap save

Expected Result:

Uploaded picture have been not rotated itself after saving

Actual Result:

Uploaded picture have been rotated itself after saving

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.88.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5676828_Image_from_iOS__44_.mp4

Issue reported by: Applause - Internal Team

Upwork job link : https://www.upwork.com/jobs/~0169e2129c15b874c0

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Justicea83
Copy link
Contributor

this can be external

@parasharrajat
Copy link
Member

@tabakharniuk Any thoughts?

@vitalii-tb
Copy link
Contributor

@parasharrajat checking

@Justicea83 Justicea83 added the External Added to denote the issue can be worked on by a contributor label Aug 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Aug 5, 2022
@michaelhaxhiu
Copy link
Contributor

@Justicea83 if you want, I can self assign and export this right now since it's daily and I looked at it already :) lmk

@Justicea83
Copy link
Contributor

@michaelhaxhiu , I've assigned you

@michaelhaxhiu
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title IOS - Profile - Uploaded picture have been rotated itself after saving. [$250] IOS - Profile - Uploaded picture have been rotated itself after saving. Aug 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @rafecolton (ring0), see https://stackoverflow.com/c/expensify/questions/6102 for more details.

@Beamanator
Copy link
Contributor

Beamanator commented Aug 24, 2022

@rafecolton would you please create a Fork of https://github.com/oguzhnatly/react-native-image-manipulator?

Here's a handy SO: https://stackoverflow.com/c/expensify/questions/10007/10008#10008 (looks like you wrote it 😆 )

@rafecolton
Copy link
Member

Done!

@rafecolton rafecolton removed the ring0 label Aug 24, 2022
@rafecolton rafecolton removed their assignment Aug 24, 2022
@Beamanator
Copy link
Contributor

Thanks @rafecolton !

Ok @tabakharniuk would you mind making a PR on that new repo (https://github.com/Expensify/react-native-image-manipulator) with your changes?

@vitalii-tb
Copy link
Contributor

Done ✅

@Beamanator
Copy link
Contributor

Thanks @tabakharniuk ! PR in the react-native-image-manipulator repo merged 👍 now can you make a PR in E/App with the updated package link? You can see how we currently do this in package.json where we link to other Expensify repos 👍 Let us know if you have questions!

@vitalii-tb
Copy link
Contributor

Done ✅
#10742 is ready for review

cc: @Beamanator

@Beamanator
Copy link
Contributor

Thanks @tabakharniuk ! I'll wait for @Santhosh-Sellavel to review first 👍

@Beamanator
Copy link
Contributor

Fix merged!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2022
@Beamanator
Copy link
Contributor

Not overdue, fix is on staging

@melvin-bot melvin-bot bot removed the Overdue label Sep 14, 2022
@trjExpensify trjExpensify changed the title [$250] IOS - Profile - Uploaded picture have been rotated itself after saving. [Bug] [$250] IOS - Profile - Uploaded picture have been rotated itself after saving. Sep 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2022
@Beamanator
Copy link
Contributor

Hmm shouldn't this have made it to prod by now?

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Yeah, It's on production, verified everything looks good! This should be due for payment.
@Beamanator

cc: @michaelhaxhiu

@michaelhaxhiu
Copy link
Contributor

Made a new job post (last one expired), and invited @Santhosh-Sellavel and @tabakharniuk. Respond here after you accept and I can disperse payment

@vitalii-tb
Copy link
Contributor

Done!
Cc: @michaelhaxhiu

@michaelhaxhiu
Copy link
Contributor

@tabakharniuk is paid, just waiting for santhosh to accept so I can pay & close this GH

@Beamanator
Copy link
Contributor

Bump @Santhosh-Sellavel

@michaelhaxhiu
Copy link
Contributor

Actually, bump for me!
Santhosh accepted a few days ago and I missed it. Paying him now ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests