-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios) Fix croped image orientation #10742
fix(ios) Fix croped image orientation #10742
Conversation
Maybe let's add this check below Test steps
Also, test steps could have information to use a live photo, which causes the issue. |
The issue is not linked properly, should be linked as shown below!
|
@Santhosh-Sellavel thanks! Fixed ✅ |
Not sure I just checked another PR, and it was fine without the PR Reviewer Checklist unfilled! Okay let me check again! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests well!
@Beamanator all you!
@AndrewGable C+ can't edit the PR description so will not be able to fill the PR Reviewer Checklist! cc: @Beamanator |
You can leave the checklist in a new comment or PR review like usual and the test should pass 👍 |
I've left a comment already, but it's still failing |
Merge main
@Santhosh-Sellavel It looks like |
Cool thanks! @tabakharniuk |
@Beamanator looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
All tests passed before merging, not an emergency |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Beamanator in version: 1.1.98-0 🚀
|
Yeah me too - good find @parasharrajat - can you review this? #10961 |
The package-lock.json change should be updated in |
Details
Fixed Issues
$ #10258
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Screen.Recording.2022-09-01.at.15.10.34.mov
Mobile Web
Simulator.Screen.Recording.-.iPhone.13.-.2022-09-01.at.14.17.22.mp4
Desktop
Screen.Recording.2022-09-01.at.15.12.30-2.mov
iOS
Simulator.Screen.Recording.-.iPhone.13.-.2022-09-01.at.15.22.29.mp4
Android
Screen.Recording.2022-09-01.at.14.11.11.mov