mweb - OlDdot - User gets infinite loading when opening a WS from old dot app

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:1. Open the Old dot Prod app

Precondition: signed out of NewDot on mobile web

1. Open the Old dot Prod app
2. Sign into a valid account (Expensifail)
3. Tap on the "Get started" on the inbox task that says "Would you like to get started with our free plan?".

Expected Result:

User is redirected to NewDot on mWeb with the workspace settings page open.

Actual Result:

The user is redirected to mweb, however the page never loads and the new workspace is never created. The user is faced with infinite loading.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.88.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+emilio456@applause.expensifail.com/Emilio98

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5677103_Old_dot_app_does_not_redirect_correctly_to_new_workspace.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[madmax330]

Will try to repro this today

[madmax330]

Focused on Global reimbursements now, will drop this back in the pool

[tgolen]

I was able to reproduce this locally. The page on NewDot sits at a spinner forever. If I refresh the page, then the workspace is created properly and everything continues as expected.

Debugging further to see what's going on.

[tgolen]

@neil-marcellini Can you help me with this? I traced the code to this and found that isLoggingInAsNewUser is false, so in effect, nothing is happening and the user stays on that page just looking at the spinner.

This happens every time I try it after I've logged off of NewDot before going from OldDot > NewDot.

It's false because my session email (which is a valid email, the same I signed into OldDot with) is the same as the email in the URL.

If that's the case, and the emails are the same, shouldn't we call Session.signInWithShortLivedToken(email, shortLivedToken);?

[tgolen]

Actually, maybe that's not it. I'm now digging into setUpPoliciesAndNavigate() because I think it's something to do with that.

[tgolen]

@arosiclair It might be related to your recent PR? #10122

[arosiclair]

@arosiclair It might be related to your recent PR? #10122

Possibly. Just gave it a few tries in dev with OldDot Web and NewDot Web and the transition worked even when Newdot was signed out. Which platforms can you repro with?

[tgolen]

I'm just doing it on web. I can repro it every time. I will try to get a video of it for you just to make sure we are doing the same things

[tgolen]

Haha, of course. When I try to record it, it works perfectly fine the first time.

I made sure I was on the latest version of main for both repos and made sure to ran npm i in both repos and composer install for web-e.

Maybe that had something to do with it. I'm going to close this since neither of us can reproduce it now.

[isagoico]

@tgolen I'm able to reproduce this issue on build 1.1.89-0 when transitioning from OldDot mWeb to NewDot when logged in with a different account in NewDot

1. Log in to NewDot with account A
2. Navigate to OldDot and log in with account B
3. Select the option to "Set up your company for free"
4. Infinite loading displayed, after a little while a empty error is shown (sometimes)

WhatsApp.Video.2022-08-24.at.11.16.15.AM.mp4

Edit: same is happening when navigating from the OldDot app to Newdot mWeb, so the original issue is still reproducible.

[tgolen]

OK, thanks for letting me know. @arosiclair is working on a little refactor to that code in this PR: #10494 so once that is deployed, let's re-evaluate if this still happens or not.

[tgolen]

Changing this to weekly for now.

[tgolen]

This kind of broke again, but @arosiclair is continuing to dig into this so I'm going to reassign this issue to him.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.