[HOLD for payment 2023-01-19] mWeb/Chrome - OldDot transition - The infinite spinner after being redirected to NewDot

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the OldDot mobile app and log in with an account that has a existing workspace policy
2. Navigate to "Settings" and tap on "View all" on the policies section
3. Tap on the "Group" tab
4. Tap on the "Edit" button next to a Workspace
5. Tap on the "Current Plan" option inside the workspace settings

Expected Result:

User is redirected to NewDot on mWeb

Actual Result:

The infinite spinner after being redirected to NewDot.
Repeat for all 3 scenarios:

• Signed out of NewDot/
• Signed in with a different account in NewDot
• Signed in with the same account in NewDot.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / Chrome

Version Number: 1.2.45.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5879948_Record_2022-12-29-10-31-03.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6d1ff001e7a42b4
• Upwork Job ID: 1611145963403091968
• Last Price Increase: 2023-01-05

[laurenreidexpensify]

• is a bug
• Not a dupe but related issues:
• mweb - OlDdot - User gets infinite loading when opening a WS from old dot app #10271
• mWeb/Chrome - Infinite spinner after redirected back to NewDot and finishing the 2FA setup #13326
• [HOLD for payment 2022-12-20] [$1000] Web - Error message is visible after redirecting via any Workspace policy + error in console #13026
• Reproducible - confirmed on my Pixel 7 handset
• GH template complete
•  Title and Body are clear
• Created by QA
• Old dot - newdot link issue
• No Slack convo
• This feels like it needs internal review cos of the olddot aspect

[alex-mechler]

Interestingly enough, I can only get this on prod, but not on staging. Looking into when we last deployed to see if maybe a fix is already released

[alex-mechler]

https://github.com/Expensify/App/pull/13600/files is the only thing I can see that might have impacted this, will retest this after that goes to prod to see if this is fixed

[alex-mechler]

Okay, still reproducing this, but I figured out the root cause. Will get a pr up

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f6d1ff001e7a42b4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[laurenreidexpensify]

On Staging

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.52-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Also check for shortLivedToken when signing in with shortLivedAuthToken #14045

If no regressions arise, payment will be issued on 2023-01-19. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif / @alex-mechler] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/13675/files
• [@aimane-chnaif / @alex-mechler] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update ShortLivedToken naming convention  #13675 (comment)
• [@aimane-chnaif / @alex-mechler] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1673566560817099
• [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: This is already covered here https://expensify.testrail.io/index.php?/cases/view/1971115&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229069

[laurenreidexpensify]

@aimane-chnaif pls accept job on upwork, thanks!

[aimane-chnaif]

@aimane-chnaif pls accept job on upwork, thanks!

@laurenreidexpensify accepted, thanks!