Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Some Unnecessary view is added above keyboard when it is active in android - reported by @Santhosh-Sellavel #10360

Closed
mvtglobally opened this issue Aug 11, 2022 · 16 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open App
  2. Go to chat window and tap on compose box
  3. Or Perform any operation that opens native keyboard

Expected Result:

No Unnecessary blocking view

Actual Result:

Some blocking view is added

Workaround:

unknown.

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.85-8
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot_1658677626
Screenshot_1658677379
Screenshot_1658677358

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658677663185129

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 11, 2022

Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 11, 2022
@ntrepanier
Copy link

Unable to recreate on my app. I'm not sure what could cause this. It looks like a code issue based on what I can find about it online. https://stackoverflow.com/questions/62051371/react-native-android-keyboard-empty-space. I'm hoping an engineer can help us figure it out.

@melvin-bot
Copy link

melvin-bot bot commented Aug 11, 2022

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ntrepanier ntrepanier added Weekly KSv2 and removed Daily KSv2 labels Aug 11, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Aug 12, 2022

So there's a huge space between the keyboard and the content? And this is in all androids? And it is in production?
If so, how did this get past QA @mvtglobally ?

@iwiznia iwiznia removed their assignment Aug 12, 2022
@iwiznia iwiznia added the External Added to denote the issue can be worked on by a contributor label Aug 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 12, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2022
@ntrepanier
Copy link

It's not on all androids. Mine is fine, which is why at first I thought it must be a local issue but nothing I found on it pointed to that.

@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2022
@JmillsExpensify
Copy link

Ok so QA can reproduce but @ntrepanier can't? In that case, I don't think it's a fire and we can use the normal contributor process.

@melvin-bot melvin-bot bot removed the Overdue label Aug 15, 2022
@JmillsExpensify
Copy link

JmillsExpensify commented Aug 15, 2022

Upwork job is here: https://www.upwork.com/jobs/~014b1754d939b81c86. We're open for proposals.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 15, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 15, 2022

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Some Unnecessary view is added above keyboard when it is active in android - reported by @Santhosh-Sellavel [$250] Some Unnecessary view is added above keyboard when it is active in android - reported by @Santhosh-Sellavel Aug 15, 2022
@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 15, 2022

@Santhosh-Sellavel is it still reproducible for you?

@Santhosh-Sellavel
Copy link
Collaborator

Not reproducible for me now.

@0xmiros
Copy link
Contributor

0xmiros commented Aug 15, 2022

The reporter @Santhosh-Sellavel tested on v1.1.85-8 but this issue is gone from v1.1.86-2 (generated on Jul 26)

This caused android keyboard issue: #9895 (Jul 20)
And reverted: #10113 (Jul 26)
Therefore, from v1.1.85-6 (on Jul 21) to v1.1.86-1 (Jul 25) was having this keyboard issue

@NikkiWines
Copy link
Contributor

Sounds like this bug may no longer be an issue. @mvtglobally can you confirm whether or not QA is able to reproduce this still?

@JmillsExpensify
Copy link

Let's proactively close until Applause is able to reproduce on the latest build. Please re-open if it fails the next round of QA. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants