iOS - Workspace - App crashes when making changes to Track distance units in offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Create a workspace while offline
4. Choose Reimburse expenses
5. In the Track distance section, I change the unit from miles to km

Expected Result:

In app, units of measure must be selectable

Actual Result:

App crashes after changing miles to km offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.99 -2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/189362228-d372d1da-0775-4836-acaa-798bd74bb26e.mp4
Bug5724572_logs_0909.log

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[0xmiros]

This crash has been fixed here: #10876 by this PR

I believe this GH will be closed after someone checks my comment above.

Question:
Is there any compensation for this kind of comment? This also takes time to research, enough more than 1 simple GH issue fix.
i.e.
#10360 (comment)
#9933 (comment)
I did hard research on these issues to find RCA and conclude that issues have been fixed successfully.
But issues were simply closed without any compensation for the final commenters.
I may ignore these kinds of issues without any comment but if so, the issues will keep remaining open or hold until another engineer researches the issue and makes conclusion after hard work.

[mvtglobally]

@jasperhuangg Cold be related to your issue?

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

@0xaim thanks so much. We appreciate your investigation, but unfortunately, this is not something we compensate for. We recommend waiting to jump into issues until the Help Wanted label has been added. You can read more in our contributing guidelines here: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

Thanks!

[0xmiros]

@puneetlath Thanks for this info
Hmm, 2 more issues I mentioned had already Exported, Help Wanted labels