[HOLD for payment 2023-02-07] [HOLD #11463] [$2000] [Bug] mWeb/iOS - Request money/Split bill - confirmation button is overlapped by the keyboard

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in with any account
2. If needed, start a chat with someone other than concierge by clicking the green plus, New chat, typing in a valid email, and selecting that person.
3. Click the plus at the bottom left, Send money
4. Enter an amount and hit next

Expected Result:

The pay button appears above the keyboard

Actual Result:

Final confirmation button is covered by the keyboard. You have to hide keyboard to see the button

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web (Safari iOS)

Version Number: 1.1.93.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5709815_RPReplay_Final1661808389.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Beamanator]

Looks like something a contributor can work on!

[JmillsExpensify]

Yes, though I thought that we decided that we're going to treat all keyboard issues centrally at the moment? I'll ask in Slack for confirmation.

[Beamanator]

Ohhhhh I think you're right

[melvin-bot]

@JmillsExpensify, @Beamanator Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Cool, I'll put a hold on this. I also posted in open-source to make sure this one is on people's radars.

[Beamanator]

Dropping priority a bit since this is on hold :D

[Beamanator]

Still on hold

[JmillsExpensify]

Still on hold, though we're going to pick up the larger keyboard initiative soon.

[JmillsExpensify]

Still on hold per the larger keyboard initiative.

[JmillsExpensify]

Still on hold, Melvin.

[JmillsExpensify]

We're discussing remaining steps to wrap up the linked issue holding this one. We should be aligned in the coming days on next steps.

[mallenexpensify]

Removed Help Wanted because job is on hold, please add back when it's off hold

[JmillsExpensify]

Closing in on addressing the linked issue. Thanks @mallenexpensify on the label.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.62-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: iOS button obstructed by keyboard #14392

If no regressions arise, payment will be issued on 2023-02-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane / @tgolen] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane / @tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane / @tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[parasharrajat]

Note: There is a regression from this PR #14716

[JmillsExpensify]

Ok great, that's probably a good reminder for us to get the BugZero checklist kicked off. @sobitneupane and @tgolen mind getting the first three kicked off given that we have a regression in play?

[sobitneupane]

@JmillsExpensify I think we can close this issue because it is being handled in #11463. This and #11463 are similar issues and have the same root cause.

[JmillsExpensify]

Huh, that's a good catch. @rawalyogendra Do you agree with this? I'll go ahead and close for now since we're also working on #11463 together, but please let us know if you think this was extra work outside the scope of that linked issue. Thanks!