Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD #11463] [$2000] mWeb - Close account - The Close account button is cut off and has extra padding #14815

Closed
1 of 6 tasks
kbecciv opened this issue Feb 3, 2023 · 22 comments
Closed
1 of 6 tasks

[HOLD #11463] [$2000] mWeb - Close account - The Close account button is cut off and has extra padding #14815

kbecciv opened this issue Feb 3, 2023 · 22 comments
Assignees
@mananjadhav @yuwenmemon @alexpensify
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 3, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to staging.new.expensify.com
  2. Login with any account
  3. Navigate to Settings > Security
  4. Click on "Close Account"
  5. Enter the email in the input and open keyboard

Expected Result:

The close account button should be visible and no extra padding

Actual Result:

The Close account button is cut off and has extra padding

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.64.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5923546_close_account_0202.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ada6ac6e030a8f27
  • Upwork Job ID: 1623041453543440384
  • Last Price Increase: 2023-02-14
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 3, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 3, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Feb 3, 2023

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 3, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Feb 3, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 3, 2023
@alexpensify
Copy link
Contributor

I'll review this one early next week.

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2023
@alexpensify
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@alexpensify
Copy link
Contributor

alexpensify commented Feb 7, 2023 •
edited
Loading

I've started a discussion here:

https://expensify.slack.com/archives/C01SKUP7QR0/p1675732294006959

@MelvinBot
Copy link

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alexpensify
Copy link
Contributor

Assigning to engineering to identify if this will be internal or external - Thanks!

@yuwenmemon
Copy link
Contributor

This will be External

@yuwenmemon yuwenmemon added the External Added to denote the issue can be worked on by a contributor label Feb 7, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 7, 2023
@melvin-bot melvin-bot bot changed the title mWeb - Close account - The Close account button is cut off and has extra padding [$1000] mWeb - Close account - The Close account button is cut off and has extra padding Feb 7, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01ada6ac6e030a8f27

@MelvinBot
Copy link

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2023
@MelvinBot
Copy link

Current assignee @yuwenmemon is eligible for the External assigner, not assigning anyone new.

@allroundexperts
Copy link
Contributor

allroundexperts commented Feb 7, 2023 •
edited
Loading

This bug is introduced as a result of #14392
#11463 and #10670

cc @rawalyogendra @flodnv @mananjadhav

@yuwenmemon
Copy link
Contributor

@allroundexperts are you saying that we already have a fix in place?

@allroundexperts
Copy link
Contributor

I meant that a PR for another bug introduced this issue. @yuwenmemon

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2023
@alexpensify
Copy link
Contributor

@yuwenmemon any feedback here to the recent reply?

@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2023
@mananjadhav
Copy link
Collaborator

@alexpensify @yuwenmemon Let's put this on hold until #11463 is resolved.

@yuwenmemon
Copy link
Contributor

@alexpensify +1 to that^

@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Feb 13, 2023
@alexpensify
Copy link
Contributor

Thanks, I've moved this to weekly to sort out the GH mentioned #11463.

@melvin-bot melvin-bot bot changed the title [$1000] mWeb - Close account - The Close account button is cut off and has extra padding [$2000] mWeb - Close account - The Close account button is cut off and has extra padding Feb 14, 2023
@mananjadhav mananjadhav mentioned this issue Feb 15, 2023
Merged
54 tasks
@mountiny mountiny changed the title [$2000] mWeb - Close account - The Close account button is cut off and has extra padding [HOLD #11463] [$2000] mWeb - Close account - The Close account button is cut off and has extra padding Feb 16, 2023
@alexpensify
Copy link
Contributor

I believe this one is still on hold.

@alexpensify
Copy link
Contributor

alexpensify commented Feb 27, 2023 •
edited
Loading

@yuwenmemon - I believe that #11463 is out. Should we take this one off hold? Thanks for checking!

@yuwenmemon
Copy link
Contributor

@alexpensify are we still seeing the bug though? I can't see it on staging anymore. Closing this out.
IMG_9EF07149126A-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mananjadhav mananjadhav

@yuwenmemon yuwenmemon

@alexpensify alexpensify

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mananjadhav @yuwenmemon @alexpensify @MelvinBot @allroundexperts @kbecciv