Web - IOU - Numbers added after decimal point are appearing preceding the decimal point

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com and login
2. Select a group and select option "Split bill"
3. Enter a decimal point and then numbers

Expected Result:

Numbers are added after the decimal point

Actual Result:

Numbers are added before the decimal point, user can't add decimal amount
(Same scenario with Request money and Send money as well)

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.1.99-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.518.mp4

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[techievivek]

@eVoloshchak Is this in any way related to your changes?

[eVoloshchak]

@eVoloshchak Is this in any way related to your changes?

Yes, I think it's a regression from #10028. I'll be able to revert the PR and verify this in ±14 hours.

[techievivek]

@eVoloshchak Any updates on this one?

[eVoloshchak]

@eVoloshchak Any updates on this one?

Sorry, having trouble with free time
It is related to #10028 simply because this PR introduced adding preceding zero if the user entered the decimal point, so it was an edge case I missed in this PR
Somehow this doesn't happen if you have currency after the amount

Screen.Recording.2022-09-15.at.21.13.34.mov

I'll look into this on the weekend

[parasharrajat]

Hmm, I am sure I tested it on that PR. Check the attached web video on that PR. Could this be related to #10147

[eVoloshchak]

Could this be related to #10147?

I don't think so, this PR changed only the updateAmountNumberPad method (the one used for on-screen keyboard), while this bug is on Web, so the problem is with updateAmount method, which was unchanged in #10147

[eVoloshchak]

Now that I think about it more, yes, it could be related to #10147. It introduced some changes to the TextInput, mainly the selection being controlled by state, there could be bugs associated with this
I'll check it, thank you

[eVoloshchak]

I checked it, #10147 was the PR that caused this, thanks @parasharrajat for pointing this out.

Solution:
This is a controlled input, but currently in updateAmount we update amount, but don't update the selection. Let's fix that

updateAmount(text) {
    this.setState((prevState) => {
        const amount = this.addLeadingZero(this.replaceAllDigits(text, this.props.fromLocaleDigit));
+       const selection = this.getNewSelection(prevState.selection, prevState.amount.length, amount.length);
        return this.validateAmount(amount)
-            ? {amount: this.stripCommaFromAmount(amount)}
+            ? {amount: this.stripCommaFromAmount(amount), selection}
            : prevState;
    });
}

Screen.Recording.2022-09-18.at.17.19.46.mov

[melvin-bot]

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

[techievivek]

Just checked with the team on how we need to handle this. I will put the updates here. Thanks

[rushatgabhane]

I'll work on the RCA

[techievivek]

I just discussed it with the team and since this is a clear case of regression we would want @eVoloshchak to push a PR fixing this.

[eVoloshchak]

If the solution I proposed looks good to you, I can push a PR

[rushatgabhane]

@eVoloshchak yea, let's do it!

[techievivek]

@eVoloshchak Hi, have you pushed a PR fixing it?

[eVoloshchak]

@eVoloshchak Hi, have you pushed a PR fixing it?

PR is up

[melvin-bot]

@techievivek Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@techievivek Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@techievivek Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@techievivek 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @techievivek eroding to Weekly issue.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mvtglobally]

Issue not reproducible during KI retests. (Third week) @techievivek Are we ok to close this one?

[techievivek]

Sorry, I agree we can close this now.