Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - App crashed when creating New room in offline #11246

Closed
kavimuru opened this issue Sep 23, 2022 · 22 comments
Closed

Workspace - App crashed when creating New room in offline #11246

kavimuru opened this issue Sep 23, 2022 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Sep 23, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #10863

Action Performed:

  1. Log in to any account
  2. Create a workspace by clicking the green plus, New workspace (if needed)
  3. Go offline
  4. Click the green plus then click New room
  5. Fill out the new room form as a restricted workspace and click save

Expected Result:

Verify that you are navigated to the newly created room and you see the "Collaboration starts here" message and everything is grayed out

Actual Result:

App crashed when try to save new room offline.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Mobile Web - Safari

Version Number: 1.2.5.0.

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers): applausetester+31622@applause.expensifail.com / Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/192025941-f59255c7-8627-491a-95c5-1cf9c5527f5e.mp4
Bug5746025_New_Expensify-2022-09-23-102958.txt

Expensify/Expensify Issue URL:

Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

FWIW I could not repro this on staging.

@johnmlee101
Copy link
Contributor

I could reproduce this on iOS

@johnmlee101
Copy link
Contributor

v1.25-0

@luacmartins
Copy link
Contributor

Oh interesting! I tried the same platform and version and didn't have an issue.
From the issue description it seems like it's also on prod so I won't block the deploy on it, but please keep investigating!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2022

@johnmlee101 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

@johnmlee101 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

@johnmlee101 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@johnmlee101
Copy link
Contributor

Can't reproduce in the latest update, so I think this might be good to close out

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2022
@johnmlee101
Copy link
Contributor

Can you retest to see if this is happening on your side?

@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2022

@johnmlee101 Eep! 4 days overdue now. Issues have feelings too...

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@johnmlee101
Copy link
Contributor

Unassigning in the meantime since I don't believe this is happening anymore

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2022
@johnmlee101 johnmlee101 removed their assignment Oct 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 19, 2022

Should this have gone to triage and then eng? It looks like it's going backwards based on our chore SO. I'm going to send to eng so they can decide if this should stay open.

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@Christinadobrzyn Christinadobrzyn removed their assignment Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2022

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@NikkiWines
Copy link
Contributor

The reproduction steps on the OP don't work for the most recent version of NewDot (staging) for me.

RPReplay_Final1666298886.MP4

@kavimuru is this still a valid flow? If so, it looks like there would be more steps necessary to reproduce this issue - could you list those out please? If not, doesn't look like this is an issue anymore.

@kavimuru
Copy link
Author

@NikkiWines Is this gmail account? For public domains "New room" option is not available.

@NikkiWines
Copy link
Contributor

Oh, yes I was using a gmail account. Let me try on a private domain

@NikkiWines
Copy link
Contributor

I'm unable to reproduce this on iOS staging v1.2.18-4. Closing since QA is also unable to reproduce this.

RPReplay_Final1666354241.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants