Deploy Checklist: New Expensify 2022-09-22

[OSBotify]

Release Version: 1.2.5-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Use new api command AddWorkspaceRoom #10863
• Fix transitions to existing workspaces from OldDot #10949
• Composer - Migrate setNativeProps to state #11033
• ComposerEdit - Remove setNativeProps #11034
• OptionsSelector - Migrate setNativeProps to state #11036
• RoomNameInput - Migrate setNativeProps to state #11037
• TextInput, SignInPageForm - Migrate setNativeProps to setAttribute #11038
• Fix OpenApp failures due to expired authToken #11151
• Focus input field follow up magic link #11163
• [No QA] Fix syntax error in upload_symbols_to_crashlytics #11182
• Correct the Onyx beta key that sidebar connects to #11188
• [No QA] chore(logging): make sure TTI is captured accurately #11206
• Revert "OptionsSelector - Migrate setNativeProps to state" #11240
• Add teamdot check to SideBarUtils.js #11244

Deploy Blockers:

• Web - Green line appears with "New" after request/cancel money #11216
• Web - App crashed after logged out from expensifail account #11234
• Chat -Green line displays after send attachment/messages offline and come back online. #11237
• [$250] [OptionsSelector] The cursor moves to the start of the input making typing hard #11239

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.5-0 🚀

[sketchydroide]

looking at the deploy blocker #11237

[luacmartins]

Checking off #11216 and #11237 since they are hard to reproduce and minor UI issues.

I can repro #11234 in prod, so checking that off too.

[luacmartins]

@mvtglobally what's the status on regression?

[mvtglobally]

@luacmartins
We are almost done.

PR ##11033 is failing due to #11221
PR #11037 is failing due to #11222. not a blocker. Checking off
PR #10863 is failing. Logging 2 issues in a bit

[luacmartins]

PR ##11033 is failing due to #11221

I think this is fine, since it's the behavior we have on prod now. Thanks for logging that issue though!

[luacmartins]

PR #10863 is failing. Logging 2 issues in a bit

@mvtglobally ok, let me know once they are logged. Thanks!

[mvtglobally]

@luacmartins Here are the issues from #10863
#11230
#11246
doesn't seem to be a blocker, but pls double check

[luacmartins]

@mvtglobally Thank you! I was able to test #10863 on iOS and it's a pass for me. I did see #11230 happening. While I wasn't able to repro #11246, another team member could repro it. However, since #11246 also happens on prod, I won't block the deploy on it.

[luacmartins]

Checking off #10863!

[luacmartins]

Waiting for #11240 to hit staging so I can test it before kicking off the deploy.

[luacmartins]

@mvtglobally is regression done?

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.5-2 🚀

[luacmartins]

I tested #11240 and it's a pass. Checking it off.

[mvtglobally]

Regression is completed

[mvtglobally]

@luacmartins Are we good to check #11244?

Do you plan to deploy today or Monday only?

[luacmartins]

@mvtglobally we are still waiting to test #11244 on iOS. It's a pass on all other platforms.

Do you plan to deploy today or Monday only?

I'm gonna deploy today, once we test #11244

[luacmartins]

#11244 is a pass.

[luacmartins]

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.5-2 has been deployed to staging 🎉