Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Cursor is missing after adding an emoji. #11221

Closed
kbecciv opened this issue Sep 22, 2022 · 6 comments
Closed

mWeb - Cursor is missing after adding an emoji. #11221

kbecciv opened this issue Sep 22, 2022 · 6 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Sep 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found we executing PR #11033

Action Performed:

  1. Go to any chat
  2. Verify that you can type text in the composer.
  3. Open emoji picker
  4. Verify that you can add emojis, and that cursor position is after emoji.

Expected Result:

Verify that cursor position is after emoji.

Actual Result:

Cursor is missing after adding an emoji.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.5.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5744435_cursor_2209.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

This is probably being introduced here #11033

@luacmartins
Copy link
Contributor

Actually, I can reproduce this on prod. So nvm my comment above.

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@francoisl
Copy link
Contributor

I can't reproduce on mWeb, neither on staging nor production on an iOS simulator. And I also can't reproduce on my Android device.

Screen.Recording.2022-09-27.at.11.35.32.AM.mov

It looks like various discussions point to #11239 / #11036 being reverted, so I imagine this was possibly a side effect of that PR that was also fixed by reverting. Going to wait for the next deploy to see if it's popping up again, otherwise will close this.

@rushatgabhane
Copy link
Member

rushatgabhane commented Sep 27, 2022

we can close this if it isn't reproducible

Reverting PR #11036 has nothing to do with composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants