Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate setNativeProps to state in Composer #11056

Closed
luacmartins opened this issue Sep 16, 2022 · 1 comment
Closed

Migrate setNativeProps to state in Composer #11056

luacmartins opened this issue Sep 16, 2022 · 1 comment
Assignees
@rushatgabhane
Labels
Engineering Monthly KSv2

Comments

@luacmartins
Copy link
Contributor

Coming from #8503, enabling Fabric requires us to migrate off setNativeProps. We should move usages of setNativeProps to state in Composer
This was referenced Sep 16, 2022
Merged
Closed
@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@michaelhaxhiu michaelhaxhiu mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushatgabhane rushatgabhane

Labels
Engineering Monthly KSv2
Projects
No open projects
RN: New Architecture
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luacmartins @rushatgabhane @roryabraham