-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer - Migrate setNativeProps to state #11033
Composer - Migrate setNativeProps to state #11033
Conversation
@rushatgabhane is this ready for review? |
yep, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well! Please complete the checklist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Carlos said :)
@stitesExpensify checklist completed :) |
|
@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Checks passed. Removing |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @luacmartins in version: 1.2.5-0 🚀
|
Heads up! I'm reverting this since it caused this blocker #11239 |
🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀
|
note: this PR wasn't reverted because culprit PR was a different one - #11036 |
@rushatgabhane yes, sorry got the PRs mixed up. I left a comment on the other issue. |
Details
setNativeProps
will not be supported in the post-Fabric world (docs). Removing it's usage is a prerequisite to enable Fabric in #8503I'm creating multiple PRs to migrate it's usage. This is one of many.
Usage of
setNativeProps
is migrated to stateFixed Issues
$ #11056
Tests
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Screen.Recording.2022-09-22.at.1.46.19.AM.mov
Mobile Web
Screen.Recording.2022-09-22.at.1.45.25.AM.mov
Desktop
Screen.Recording.2022-09-22.at.1.46.46.AM.mov
iOS
Screen.Recording.2022-09-22.at.1.49.19.AM.mov
Android
WhatsApp.Video.2022-09-22.at.01.47.47.mp4