[HOLD for payment 2022-11-22] [$250] Routing number field doesn't get auto focused after opening the page reported by @Puneet-here

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to settings > workspace > connect bank account
2. Connect manually

Expected Result:

Routing number field should get focused

Actual Result:

It doesn't get focused

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.9-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

FMLR8413.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663687968571139

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We can use autoFocus here

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 116 in 7c29d89

<TextInput

[zanyrenney]

I can't repro this, but from the video, it looks good for eng triage and the solution above seems like a good one!

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MitchExpensify]

Upwork Job

[16NTU116]

Proposal

It can be solved by the following:

1. Using autoFocus prop. Reference
2. Use ref prop by setting it in componentDidMount or in useeffect

[melvin-bot]

@MonilBhavsar, @MitchExpensify, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MonilBhavsar]

@Santhosh-Sellavel could you please take a look at the proposals when you get chance

[Santhosh-Sellavel]

@Puneet-here Can you add the behavior(recordings) of all platforms here after applying your proposal, thanks!

[Santhosh-Sellavel]

Also @MonilBhavsar Please confirm if the autofocus is expected here with the design/product team. Autofocus creates weird keyboard issues in native I believe intentionally we don't set autofocus, thanks!

[Santhosh-Sellavel]

@MitchExpensify or @MonilBhavsar
Due to Limited Availability unassigning this one. Can you reapply the external label to get another C+ assigned thanks!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @MitchExpensify A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/242699
• @rushatgabhane @MonilBhavsar The PR that introduced the bug has been identified. Link to the PR: (Not a regression. Missed improvement while adding the form)
• @MitchExpensify The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: This was introduced when the field was implemented
• @MitchExpensify A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C02NK2DQWUX/p1669855888510369
• @MitchExpensify Payment has been made to the issue reporter (if applicable)
• @MitchExpensify Payment has been made to the contributor that fixed the issue (if applicable)
• @MitchExpensify Payment has been made to the contributor+ that helped on the issue (if applicable)

[MonilBhavsar]

The PR that introduced the bug has been identified. Link to the PR:

I think this was missed and not a regression by any PR. @rushatgabhane thoughts?

[rushatgabhane]

@MonilBhavsar agree. This isn't a regression

[MitchExpensify]

Seeing as this wasn't a regression, I'm thinking that this step can be skipped in this case:

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I'm undecided if this still makes sense for the same reason:

. A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Curious what you think @puneetlath ?

[puneetlath]

In that case, I think the offending PR would be the one that created this feature.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.27-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add auto focus to routing number field #12513

If no regressions arise, payment will be issued on 2022-11-22. 🎊

[MitchExpensify]

I think the offending PR would be the one that created this feature.

Thats fair. @MonilBhavsar / @rushatgabhane mind tracking that down and linking here?

[MitchExpensify]

Made a note on my cal to pay on 11/22

[rushatgabhane]

will get to this in 1-2 days. have a huge backlog

[MitchExpensify]

Paid @Puneet-here for reporting bonus and fix

@rushatgabhane sent you an invite for C+ payment

[rushatgabhane]

@MitchExpensify the offer expired yesterday maybe

Orr it is accepted. I'm not sure

[MitchExpensify]

@rushatgabhane All good! It is accepted. Payment made > Contract ended

[MonilBhavsar]

Are we good to close this now?

[rushatgabhane]

@MonilBhavsar yes good to close.
reporter, c and c+ all paid

[MonilBhavsar]

Thanks! I see the the checklist needs still needs to be completed #11423 (comment)

[MonilBhavsar]

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

Not a regression. May be It is like this since it was introduced.

A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

I think when we add a form component, PR author can start a discussion in slack if we want to autofocus field when we open the form. In this way we can prevent these kind of bugs.

cc @MitchExpensify

[melvin-bot]

@rushatgabhane, @MonilBhavsar, @MitchExpensify, @Puneet-here Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rushatgabhane, @MonilBhavsar, @MitchExpensify, @Puneet-here Eep! 4 days overdue now. Issues have feelings too...

[MitchExpensify]

Sorry I've been sick the last few days! Started the discussion about how to avoid this going forward here