Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mange members - Deleted offline member looks crossed out. #11509

Closed
kbecciv opened this issue Oct 1, 2022 · 4 comments
Closed

Mange members - Deleted offline member looks crossed out. #11509

kbecciv opened this issue Oct 1, 2022 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in an any account
  2. Navigate back to Workspace editor
  3. Click on Manage Members
  4. Kill the internet connection
  5. Select the user from the list
  6. Click on remove and confirm the modal

Expected Result:

Deleted member should be deleted and not visible

Actual Result:

Deleted offline member looks crossed out.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5758031_members_1.10_video.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 1, 2022
@kbecciv kbecciv changed the title IOS - - Members - Deleted offline member looks crossed out. IOS - Mange members - Deleted offline member looks crossed out. Oct 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Oct 1, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2022

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title IOS - Mange members - Deleted offline member looks crossed out. Mange members - Deleted offline member looks crossed out. Oct 1, 2022
@luacmartins
Copy link
Contributor

I think this is the expected behavior that we are introducing in this PR . I asked for confirmation here before closing this issue.

@luacmartins
Copy link
Contributor

luacmartins commented Oct 3, 2022

Yup, the design doc confirms that this is the expected behavior - FYI @kbecciv. Closing this issue.

Screen Shot 2022-10-03 at 9 48 52 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants