Deploy Checklist: New Expensify 2022-09-30

[OSBotify]

Release Version: 1.2.11-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Migrate policy API to remove policy members #10452
• upgrade react-native-svg version to 12.4.4 #10827
• Form refactor bankaccountstep #10900
• Create updateCompanyInformationForBankAccount in App #11026
• Use context for withWindowDimensions #11290
• Add FullPageOfflineBlockingView to ReimbursementAccountPage #11360
• Remove message and error on ResendValidationForm load #11361
• [No QA] Change reportID type from number to string #11362
• Navigate user to locally stored subStep after coming back online #11422
• Use Context for blockedFromConcierge #11441
• Add isDrawerReady method #11455
• Fix onfido flow #11466
• Update expensify-common #11467
• Add early return to ActiveClientManager #11539
• [CP Staging] save routingNumber and accountNumber in connectBankAccountManually #11556
• Fix masked account number and default values #11616

Internal QA:

• Render banner in Concierge chat #11363 - @cead22 @luacmartins

Deploy Blockers:

• [$500] The account number is masked and you can't move forward with VBA flow - Reported by @Puneet-here #11318
• Group - When creating a group/1:1 chat, a message is displayed that the group is not online #11503
• Web - Send Money- App crashed after click on Send Money #11504
• Mange members - Deleted offline member looks crossed out. #11509
• Connect Bank Account - Unable to proceed in VBA flow after change the correct account number #11510
• Chat - When sending a message to a new user, it is repeated and remains in the compose box #11526
• PR 34984 - Issue 1 - ignore it  #11548
• Chat - "Don't have access to this chat" page is shown for a brief moment while creating a new chat reported by @thesahindia #11555
• Bug : Left Hand Nav (LHN) populated at top with many zero dollar balances or "$0 balances not being removed so they're showing in LHN" #11596
• Fix logic for if a report has an outstanding IOU #11610

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.11-1 🚀

[mvtglobally]

Regression is almost completed.

Deploy Blockers
#11503
#11504
#11509
#11526

Interim summary
PR #10900 (comment) Internal QA
PR #10827 is failing due to #11504
PR #11026 is failing due to #10524 & #10510

[sketchydroide]

removing #11504 as a deploy blocker.

[luacmartins]

Tested #11363 on staging and it's a pass 🎉 Checking it off

[luacmartins]

#11509 is the intended behavior. Checking off.

[luacmartins]

I randomly reproduced #11504, but did not follow the test steps in that issue. This is the line that caused the crash, which comes from this PR in the checklist. I put up a fix here

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.11-2 🚀

[mvtglobally]

checking CP

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.11-2 has been deployed to staging 🎉

[mvtglobally]

@luacmartins
Regression is completed. CP pass
checking off #10900 (comment) as well

[mvtglobally]

Outstanding issues
PR #10827 is failing due to #11504. Are we ok to check off since blocker label removed
PR #11026 is failing due to #10524 & #10510

[AndrewGable]

#10827 seems OK to check off

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.11-3 🚀

[marcaaron]

This feels like a possible deploy blocker:

https://expensify.slack.com/archives/C01GTK53T8Q/p1664918444481379

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.11-3 has been deployed to staging 🎉

[luacmartins]

Tested #11510 and it's a pass. Checking off #11510, #11026 and #11556

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.11-4 🚀

[luacmartins]

Tested #11616 and it's a pass. Checking off #11616 and #11318!

[AndrewGable]

[luacmartins]

Checking #11610 off since the blocker label was removed.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.11-4 has been deployed to staging 🎉