[No QA] Change reportID type from number to string

[tgolen]

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/227425

• HOLD on Web-E PR https://github.com/Expensify/Web-Expensify/pull/34976

Tests

1. Select a chat in the LHN
2. Verify that the row in the LHN shows that the chat is selected (it has a slightly darker background than the rest)

There are a few propType warnings that happen regarding the IOU chat reportIDs, but that API is not fully migrated over to an OfflineFirst world, so those will be fixed later when it's migrated.

• Verify that no errors appear in the JS console

QA Steps

1. Select a chat in the LHN
2. Verify that the row in the LHN shows that the chat is selected (it has a slightly darker background than the rest)

• Verify that no errors appear in the JS console

[danieldoglas]

Tests are failing. Overall changes look good to me, but I added a question that might be mostly because I don't fully understand props on ReactNative.

[danieldoglas]

Question: since reportID is required here, won't it break the usages where reportID was not required (or even existed) in the props where it was not necessary? files?

[tgolen]

Yeah, so I ended up removing the .isRequired here, however, I not sure what you mean by "files". A report cannot exist in Onyx without a reportID since the collection is keyed by reportID (but not all reports going to the props comes straight from Onyx either).

[danieldoglas]

I mean other JS files like src/pages/home/report/ReportActionsList.js, that was not requiring reportID.

But I think removing isRequired solves it! Thanks!

[danieldoglas]

LGTM

[melvin-bot]

@danieldoglas looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[danieldoglas]

not emergency

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @danieldoglas in version: 1.2.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[aldo-expensify]

I think this PR may have missed these places:

• Shouldn't the client generated reportIDs be strings too?
  

  App/src/libs/ReportUtils.js

  Lines 577 to 579 in 87921ca

  	function generateReportID() {
  	return (Math.floor(Math.random() * (2 ** 21)) * (2 ** 32)) + Math.floor(Math.random() * (2 ** 32));
  	}

App/src/pages/home/report/ReportActionItemCreated.js

Line 18 in 87921ca

reportID: PropTypes.number.isRequired,

There are some iouReportID and chatReportID as numbers, but from the PR description I'm getting that these were intentionally skipped, is that correct?

[tgolen]

Ah, I did totally miss gernerateReportID(). Good catch. Do you want to do a PR on that?

I did intentionally skip the others, yes, since it looked like those APIs had not been migrated over to NewDot APIs yet in PHP. I didn't want to make any changes on the old API endpoints.

[aldo-expensify]

Ok! I'll do it

[OSBotify]

🚀 Deployed to production by @AndrewGable in version: 1.2.11-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅