Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - When sending a message to a new user, it is repeated and remains in the compose box #11526

Closed
kbecciv opened this issue Oct 2, 2022 · 14 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 2, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Log in any account
  3. Click New chat
  4. Open conversation with new user
  5. Send message this new user.

Expected Result:

Compose box must be empty after sending a message to a new user

Actual Result:

When sending a message to a new user, it is repeated and remains in the compose box

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.11.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5759178_Recording__1443.mp4
Bug5759178_compose_box_1.10.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 2, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2022

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@AndrewGable AndrewGable removed the DeployBlockerCash This issue or pull request should block deployment label Oct 4, 2022
@AndrewGable
Copy link
Contributor

Removing deploy blocker because fire room was created.

@melvin-bot melvin-bot bot closed this as completed Oct 4, 2022
@mallenexpensify
Copy link
Contributor

@AndrewGable , it appears we have multiple 'message stays in compose box' GH issues. was this one fixed? What's fireroom you mentioned above?

@melvin-bot

This comment was marked as off-topic.

@AndrewGable
Copy link
Contributor

Fireroom: https://expensify.slack.com/archives/C04549KMEN6

This one was fixed via #11552

@mallenexpensify
Copy link
Contributor

Dropped this into the #fireroom

This issue of text disappearing when typing after sending a chat is still happening to me on staging Version 1.2.12-0 . Is it supposed to be fixed with #11552 and #11526 ?

2022-10-06_08-03-35.mp4

@mallenexpensify
Copy link
Contributor

^ nvm, separate, and equally annoying bug, #11490

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Oct 6, 2022

@youssef-lr since you're assigned to this issue, can you please do an RCA? The template is here. If you know the offending PR that caused the bug, the employee or C+ who worked on that PR should do the regression. Reopening til the RCA is done.

I've added the high-level deets to the RCA Sheet

@youssef-lr
Copy link
Contributor

Server-side fix has been deployed to staging and I can confirm I can longer reproduce this.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@youssef-lr
Copy link
Contributor

This has been fixed. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants