Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #8503] : Reintroduce shouldFocusOnSelectRow in OptionsSelector after Fabric is enabled #11679

Closed
rushatgabhane opened this issue Oct 7, 2022 · 8 comments
Assignees
Labels

Comments

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 7, 2022

Context

shouldFocusOnSelectRow was temporarily removed from OptionsSelector in #11673 because migrating from setNativeProps to state led to regeressions.

This is a tracking issue to reintroduce shouldFocusOnSelectRow after Fabric has been enabled (as discussed here).

Steps to reintroduce shouldFocusOnSelectRow

  1. Revert OptionsSelector - remove setNativeProps #11673
  2. Make sure to remove findNodeHandle like in Remove unnecessary findNodeHandle #11657
  3. Apply OptionsSelector - Migrate setNativeProps to state #11036
@rushatgabhane rushatgabhane added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2022

Triggered auto assignment to @jliexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 7, 2022
@rushatgabhane
Copy link
Member Author

@jliexpensify feel free to unassign, and sorry for the ping (i can't change labels).

@rushatgabhane
Copy link
Member Author

Holding on #8503

@jliexpensify jliexpensify removed their assignment Oct 9, 2022
@jliexpensify
Copy link
Contributor

@rushatgabhane do you want me to assign this to you?

@rushatgabhane
Copy link
Member Author

rushatgabhane commented Oct 9, 2022

@jliexpensify sure

@rushatgabhane
Copy link
Member Author

could you please also make this a monthly? @jliexpensify

@jliexpensify jliexpensify added Monthly KSv2 and removed Daily KSv2 labels Oct 9, 2022
@hannojg
Copy link
Contributor

hannojg commented Oct 10, 2022

Important to mention: I think the function can already be added back today, as for none fabric and fabric the TextInput component has an undocumented function called setSelection.
See this comment for more details: #11053 (comment)

@rushatgabhane
Copy link
Member Author

rushatgabhane commented Oct 17, 2022

Because of @ hannojg's suggestion, this issue isn't needed anymore.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants