Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-01] Investigate overuse of Onyx in VBBA setup flow #11777

Closed
nkuoch opened this issue Oct 12, 2022 · 13 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2

Comments

@nkuoch
Copy link
Contributor

nkuoch commented Oct 12, 2022

Coming from #11770 (comment)

@nkuoch nkuoch self-assigned this Oct 12, 2022
@nkuoch nkuoch added Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Oct 23, 2022

Will try to work on it next week

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Nov 1, 2022

no update

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2022
@laurenreidexpensify laurenreidexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 3, 2022
@nkuoch nkuoch added Weekly KSv2 Task and removed Daily KSv2 Improvement Item broken or needs improvement. labels Nov 3, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Nov 10, 2022

image

@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Nov 21, 2022

No time for this yet

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 30, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Nov 30, 2022

No update

@melvin-bot melvin-bot bot removed the Overdue label Nov 30, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@JmillsExpensify JmillsExpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Dec 8, 2022
@JmillsExpensify
Copy link

My two cents: This isn't technically a bug as much as much as a performance improvement. I removed the bug label as a result.

@nkuoch nkuoch added Monthly KSv2 and removed Weekly KSv2 labels Dec 12, 2022
@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Dec 12, 2022

It's because we save in Onyx after each key types in the input field. Alternative would be to put it in the state while we type, and in onyx only on blur .. but not sure it's worth fixing.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jan 25, 2023
@melvin-bot melvin-bot bot changed the title Investigate overuse of Onyx in VBBA setup flow [HOLD for payment 2023-02-01] Investigate overuse of Onyx in VBBA setup flow Jan 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-01. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 25, 2023

Nothing from Contributor. Closing.

@nkuoch nkuoch closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants