Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-02] [$1000] VBA - Connect to plaid button does not respond #14505

Closed
6 tasks done
kbecciv opened this issue Jan 24, 2023 · 11 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account
  3. Profile > Workspace > Connect bank account > Connect to Plaid

Expected Result:

User expects the VBA flow to open and load

Actual Result:

Nothing happens, the button does not respond

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.58.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2060.mp4
Connect.with.plaid.isnt.working.mp4

bae

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0143e936a0b5cae24a
  • Upwork Job ID: 1617826994065350656
  • Last Price Increase: 2023-01-24
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 24, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 24, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MariaHCD
Copy link
Contributor

Possibly related to: #13236 (comment)

Although, I can't seem to reproduce this on dev 🤔

@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0143e936a0b5cae24a

@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 24, 2023

Current assignees @robertjchen and @nkuoch are eligible for the External assigner, not assigning anyone new.

@nkuoch
Copy link
Contributor

nkuoch commented Jan 24, 2023

@dylanexpensify can you remove the upwork job and unassign yourself? I didn't want to add the external label, it was a mistake.

@dylanexpensify
Copy link
Contributor

Unassigned, removed job posting!

@luacmartins
Copy link
Contributor

I'll close this issue since the PR fixing this blocker was tested in staging and it's a pass. Thanks for the quick turnaround @nkuoch!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jan 26, 2023
@melvin-bot melvin-bot bot changed the title [$1000] VBA - Connect to plaid button does not respond [HOLD for payment 2023-02-02] [$1000] VBA - Connect to plaid button does not respond Jan 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jan 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.59-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-02. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants