[HOLD for payment 2023-02-01] Console error appears when clicking Save&Continue without selecting the bank account after successful plaid flow.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Select Connect bank account for any workspace
2. Choose connect online with plaid option
3. Complete the plaid selection flow by selecting multiple accounts
4. After navigating to our app try to click Save and continue button without selecting account from the dropdown
5. Observe the console as it will throw an error

Expected Result:

Should show the related error(Choose the account plz) and console error shouldn’t be there

Actual Result:

Console error(Cannot read properties of undefined (reading ‘routingNumber’))

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.39-0
Reproducible in staging?: y
Reproducible in production?: Could not check
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1102.mp4

Screen.Recording.2022-12-14.at.7.11.10.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671026877428529

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[thienlnam]

Nabbing this and taking it internal to complete - you shouldn't be able to hit Save & Continue without selecting the bank account

[thienlnam]

I've been digging into this and found out why this happens

When we load that page, we get the selectedPlaidAccountID from

App/src/pages/ReimbursementAccount/BankAccountPlaidStep.js

Line 65 in 91f7bac

const selectedPlaidAccountID = ReimbursementAccountUtils.getDefaultStateForField(this.props, 'plaidAccountID', '');

the reimbursement account draft

App/src/libs/ReimbursementAccountUtils.js

Lines 24 to 27 in 91f7bac

	function getDefaultStateForField(props, fieldName, defaultValue = '') {
	return lodashGet(props, ['reimbursementAccountDraft', fieldName])
	|| lodashGet(props, ['reimbursementAccount', 'achData', fieldName], defaultValue);
	}

Basically, if we've already gotten to this step and select an account, we'll have stored the bank account in that onyx key. So when you come back to it, it grabs that selectedAccountID from the old bank account

[thienlnam]

An easy way to reproduce is

1. Create a workspace, add a new bank account and select a bank account on that screen
2. Exit out, and then go through the process again connecting with plaid and notice that even when you are shown 'Choose an account', the button is visible.

You can just fix it by signing out which will clear your onyx data.

This problem only happens when you decide to go back and reconnect to another bank account with plaid.

[nkuoch]

Should be fixed by #13236

[flaviadefaria]

As a note, I'm going to be OOO from Dec 23rd to January 9th. In case this needs to be paid before the week of January 9th then please reassign.

[flaviadefaria]

@nkuoch and @thienlnam can I close this GH given this will be fixed by #13236?

[nkuoch]

Let's keep it open, and it will close once the PR is deployed. Meanwhile, let's just switch it to weekly

[melvin-bot]

@nkuoch, @thienlnam, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

Linked PR #13236 is in review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix and refactor VBBA setup flow #13236

If no regressions arise, payment will be issued on 2023-02-01. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch / @thienlnam] The PR that introduced the bug has been identified. Link to the PR: I think the bug has always been there
• [@nkuoch / @thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@nkuoch / @thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@flaviadefaria] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/257636

[flaviadefaria]

Switching this back to daily so that I don't miss payment.

[flaviadefaria]

Chill Melvin, I'm only paying them on the 1st.

[flaviadefaria]

I'm going to issue payment to @Pujan92 for reporting the bug. Once that's done are we good to close this @nkuoch and @thienlnam?

[flaviadefaria]

Payment has been made to @Pujan92. I'm going to close this, but please reopen it in case I missed something.