[HOLD for payment 2023-02-01] [Hold #13501] Connect Bank Account - Endless loading is shown when navigate to Connect Bank Account

[JmillsExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with your testing account
3. Navigate to Setting - Workspace - Workspaces
4. Create an OPEN bank account (this state means the bank account is ready for reimbursement):

• Add Bank Account (On new dot enable Settings > Preferences > Use Secure staging server to hit our staging secure sandbox):

  • Click "Log into your bank"

  • Plaid modal - Choose Wells Fargo (use Bank of America if Wells Fargo is not available)

  • Plaid modal - User Id: user_good

  • Plaid modal - Password: pass_good

  • Plaid modal - Submit

  • Plaid modal - If they request a verification code via mobile sms, enter: credential_good when required

  • Choose an account: Plaid Saving11122XXXXXX111

  • Save & Continue

• Company Information (Enter anything unless specified):

  • Legal Business Name: Alberta Bobbeth Charleson

  • Company website: Enter any valid formatted website

  • Tax ID number: 123456789 (any nine digits) must be 123456789

  • Industry classification code: 123456 (any six digits)

  • Confirm company is not on list of restricted businesses

• Requestor Information (Enter anything unless specified)

  • First name: Alberta

  • Second name: Charleson

  • Toggle confirmation you are authorized to use company bank account

  • Save & Continue (Note: You will receive an error asking to "Please verify you name and date of birth". Hit "Save & Continue" again without changing any inputs.)

• Onfido (skipped)

• Beneficial Owners

  • Toggle terms and conditions

  • Toggle confirmation that the information provided is true and accurate

Expected Result:

You should see the message "You're all set!" under Connect Bank Account Page

Actual Result:

Once the modal closes, you're back at New Dot with an infinite loading spinner.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.33-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[JmillsExpensify]

Please see #12670 for more commentary.

[JmillsExpensify]

@ctkochan22 I went ahead and proactively assigned you.

[Luke9389]

Making a quick correction on the description, the TaxID has to be 123456789.

Context: https://expensify.slack.com/archives/C03TQ48KC/p1669423123408509

[JmillsExpensify]

Thank you! 🙌🏼 Also @Luke9389 apologies if you were taking this one instead. That part is up to ya'll!

[ctkochan22]

@JmillsExpensify Having a small family emergency that I mentioned earlier this week, so I'm not sure if I can get to this this week. But happy to take it

[nkuoch]

Stealing it from you then @ctkochan22 :)

[nkuoch]

I couldn't actually reproduce it myself, but hopeful that https://github.com/Expensify/App/pull/13236/files#diff-d8218c24eeebd8e3101efe3934ab8a4478d9bd34f3c8570b58b2fb8f43f31559R71 might fix it

[kbecciv]

Per request on this issue #12670 (comment)

1. Issue is reproduced on any accounts.
2. username and password kbecciv+1031abb2@gmail.com/Feya86Katya

[nkuoch]

@kbecciv can you share all the details on how you reproduce it? (like device, browser, credentials, etc..), and record a video of what you're doing?

I'm not getting any infinite loading when trying to reproduce it from your account.

I signed into https://staging.new.expensify.com/ in chrome with kbecciv+1031abb2@gmail.com/Feya86Katya

Then went through the flow, and ended up on this step:

2022-12-06_11-02-52.mp4

[ctkochan22]

@kbecciv I also can't reproduce

[kbecciv]

@nkuoch Please check the video in comment #12670 (comment)
Used credentials: kbecciv+1031abb2@gmail.com/Feya86Katya
Web - Chrome browser
IOS app - iPhone 8/14.2

[melvin-bot]

@nkuoch, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

This is hold on #13501

[laurenreidexpensify]

Still held on

• [Form Refactor] ACHContractStep #13501

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix and refactor VBBA setup flow #13236

If no regressions arise, payment will be issued on 2023-02-01. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter - NA
• Contributor that fixed the issue - NA
• Contributor+ that helped on the issue and/or PR - NA

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch] The PR that introduced the bug has been identified. Link to the PR: N/A: I could actually never really reproduced the bug, but guessed how to fix it. Corresponding code had always been there.
• [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/259798

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[laurenreidexpensify]

@Christinadobrzyn can you handle the payment for C+ review from Santhosh + regression test pls, am still OOO thanks

[Santhosh-Sellavel]

There is no amount due, I just did some initial review post that I didn't continue the review due to my unavailability & also this would need internal engineers to test this one so no other C plus was assigned here, thanks!

[Christinadobrzyn]

Catching up, as Santosh mentioned, it looks like internal eng/QA were the only ones working on this so I don't see any external payment. @nkuoch can you let me know if that's incorrect? I'll work on the regression test.

[nkuoch]

Correct

[Christinadobrzyn]

Regression test buddy check - https://expensify.slack.com/archives/C01SKUP7QR0/p1675215255219549

[Christinadobrzyn]

• Looks like this can be closed as the issue can't be reproduced and it's been in prod for over 7 days.
• Since there wasn't a C+, no external reporter, and no contributor, there are no external payments for this job
• Closing please feel free to reopen if needed.