Deploy Checklist: New Expensify 2023-01-23

[OSBotify]

Release Version: 1.2.58-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix and refactor VBBA setup flow #13236
• Fix newMarker disappearing when deleting the comment that was marked unread. #14032
• composer icons tooltip position fix #14247
• Fix unread indicators test #14375
• Downgrade onfido UI version to fix vulnerability #14414
• Replace smart dash with double hyphen #14419
• Set initialValue right after date picker is shown on iOS #14427
• fix: Message actions popover not showing after open app download links page and go back #14431
• [NO QA] Fix proptypes warning in MenuItemWithTopDescription #14435
• [CP Staging] Fix crash after log out #14450
• [No QA] Filter out reportActionID-keyed Onyx updates #14455
• Revert "[No QA] Filter out reportActionID-keyed Onyx updates" #14484
• Fix missing import preventing opening Plaid modal #14508

Deploy Blockers:

• Chat - The loading animation is not occurring when more messages need to be loaded in chat #14503
• [HOLD for payment 2023-02-02] [$1000] VBA - Connect to plaid button does not respond #14505

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.58-1 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.58-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.58-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.58-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.58-4 has been deployed to staging 🎉

[luacmartins]

@mvtglobally could you please share an update on the regression status? I see that we are close to being done!

[mvtglobally]

@luacmartins We are almost done. retesting blockers. I will post update in few min

[mvtglobally]

@luacmartins Regression is completed

PR #13236 - we are retesting as #14508 was fixed
PR #14032 is failing #14488. Repro in PROD ok to check off?
PR #14375 is failing #14494. Repro in PROD
PR #14414 is pass on Web/Desktop and mWeb. But we are blocked on Apps as flow is not working. Ok to checkoff?

[luacmartins]

• Checking off Fix newMarker disappearing when deleting the comment that was marked unread. #14032 and Notifications - Notification is shown for deleted message in the Notification Centre for user A. #14494 since they are reproducible in prod. I pinged the author of each PR in the new issues so they can help address them.
• We can check Downgrade onfido UI version to fix vulnerability #14414 off since the flow is different on mobile and the country selection does not show up.

[luacmartins]

@mvtglobally is testing done for #13236?

[mvtglobally]

@luacmartins We are a bit stuck with it.
When you go back it goes to connect manually. I am asking few other team members to check.

Recording.241.mp4

[luacmartins]

@mvtglobally I tested the PR and it seems to be a pass. Are you still having issues?

[mvtglobally]

We are not able to proceed with this one. If you want to validate internally and check it off, it will be faster

[luacmartins]

Checking off #13236 since I tested internally.

[chiragsalian]