Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web -OldDot Transition - New workspace is displayed without a name initially #11910

Closed
kbecciv opened this issue Oct 17, 2022 · 11 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Oct 17, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to NewDot and log in with a existing account
  2. Navigate to OldDot and log in with the same account from the previous step
  3. Navigate to Settings > Policies > Group and note the number of free policies
  4. Click on the "New Policy" button/"Free" option
  5. Verify you're redirected to NewDot, that you're logged in with the same account
  6. Verify that only 1 new Workspace has been created

Expected Result:

The new workspace should appear with a name immediately

Actual Result:

The new workspace is displayed without a name initially

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.16.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5780379_Recording__2434__2_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@yuwenmemon
Copy link
Contributor

Policy is getting created and stored with no name:
Screen Shot 2022-10-18 at 1 33 36 PM

@yuwenmemon
Copy link
Contributor

Looks like we're sending folks to NewDot without the ownerEmail param:
Screen Shot 2022-10-18 at 1 41 55 PM

@yuwenmemon
Copy link
Contributor

Ah we're even just sending it as the string, "undefined"
Screen Shot 2022-10-18 at 1 53 29 PM

@yuwenmemon
Copy link
Contributor

And yeah, this is the URL that gets created in Web:

"http://localhost:8080/transition?accountID=2&email=yuwen%40expensify.com&shortLivedToken=6291E7AA614740A8B4AFD655D6F2E3EC378F5BC2BA6674FFD0FB0F4DCDD61F232F660C98D4E6D8966430E70837D086BC29785D1EABEAE2BC8F4B670026B15642D64D9A151B6D73CDC4A8A568BB99A8A3C698C1D148C32B51C84331B21C4F4BE058447B6091B0B30641A7DA369BCB5743EE5130464F5BA4CE3DC7EEDA1E50B1DC86B40B828A8B1229EFA8E17C518571A2806A0340200A3230FAD5E3DBFCCC1E499AC6E4979CA2016B714C95B47CD22BE4C7E6CA19C31817A5084311F07DE8DEA88F352E70867E6EFA3141F061AD75285EE007F5CD0B063E4B7087A33F6961B8DE079849B28ED3DC12486FF5BA2164F3BB4BF1BAE8B8402677DD0FFAA0C6ADEB5824D77E04B167EDC396A564D133A2AB31D1A209D61088849B4AD321FED8E4FDB1&encryptedAuthToken=v%2FnbTBU4xIZZOwlyQbepsIvubPsqZYJUmC4Ddx6v%2FJS7R3dJXnzqbAf40WJ53VEah2Rx7jSJYoEpR6cs%2FIZAGdeiGQrnGNabB87hfKWGbO4VDudECw805mhu0gfblbFoTqj%2B%2Fc5EV49S65D9dLNW8M%2Be7DfyJytQ7yTJihs9XdGsyuPSBWIXdPJFreNNgQRYJQq46YIzPrY%2FsWO%2BXXDs6IMxk179tS4ALRNg18ieMaEGZA0tiavXHbmpKIt6vN9MVJQ8XSIjrQdDq8xH3ZDKbi6ulOUWjY1hcCwlcwPkA%2B19ZcbzFMfJKX1PNKQgriEZoUAObn3WwsL%2BhD5ho2BJuju1ny25Z5cAQIwlu78353Acl%2B6amD1ncXJEojdTdzCMQIiUkWvTYspWIovegV1rLrPw2vYAuasvHB8p6hZ43AGBIsEtWmWrKGL1PC7R%2Fn2HOmRddiACwVJPD%2B8HspAIfsuYRmUZ1UEziWV%2FCU%2BAgVj4j0ZBhb8YWZ7UAmkkmNPvrFcqOE3v0fcyHX0mHa%2FG6vD%2FCYCDhuVBhCzfKvHN8IydtxLg%2Fn3%2FhCOr1Qj6kf1cznU96vLgZHG673o%2F2DanGKz4bT%2BY4C2i%2FaaVVKJyjnbihPuuMIdeyBpmXUoNzmQ0QZEzmf%2FjvoYRq4gxcgY8wgLGZ8jkuuOt6X2Pn2FSTuCZO8HRnmyC8GNSePPyWPEze%2BbSzoXcRWB79kKJyiXqj1rTI5jVlKKtwuF%2FK%2FnHPpLHtCQVM4P3uvGxtQPJbKHdk04h6HVRz3NZS9BelncNtouc90GMmZZsCa077ejqmgyjhIbAUL9ALrI%2BXH1rW1JDlDOslV%2FIVGhiiPXcgeAE1w%3D%3D&exitTo=workspace%2Fnew&ownerEmail=undefined&makeMeAdmin=undefined"

ownerEmail=undefined&makeMeAdmin=undefined

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2022

@yuwenmemon Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

@yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Nov 1, 2022

@yuwenmemon 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

@yuwenmemon 10 days overdue. I'm getting more depressed than Marvin.

@yuwenmemon
Copy link
Contributor

That's because I fixed it and it was deployed to production more than a week ago 😅

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants