Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#11910] Chat - Two admis and two announce rooms have been created after click Create a Free Policy in OldDot #12061

Closed
kbecciv opened this issue Oct 21, 2022 · 16 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Oct 21, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12013

Action Performed:

  1. Log in staging.expensify.com
  2. Create a new account and validate it
  3. After set a Password - Create Control Policy
  4. Go to Settings - Policy
  5. Select New Policy
  6. Select Free Policy
  7. Flow will direct you to NewDot
  8. Check admin policy

Expected Result:

One admis and One announce rooms have been created after Create a Free Policy

Actual Result:

Two admis and two announce rooms have been created after click Create a Free Policy in OldDot
Also one admin and one announce is showed as Unavailable, but after refresh it shows as normal.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18.4

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any new Control Policy

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (13)

Recording.1495.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 21, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2022

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sketchydroide
Copy link
Contributor

@mountiny sorry man, can you check if your PR broke this, QA are saying this was introduced with #12038

@mountiny
Copy link
Contributor

Asked @alex-mechler as this would have to be related to the initial logic change rather than the follow up fix of syntax

@francoisl
Copy link
Contributor

Thanks for reporting @kbecciv. We've been investigating and figured this is not a blocker:

Two admins and two announce rooms have been created after click Create a Free Policy in OldDot

This is now normal, and is related to #12013. The behavior is currently different on production because that PR has not been deployed to production yet.

Also one admin and one announce is showed as Unavailable, but after refresh it shows as normal.

@alex-mechler was able to reproduce this on production, so it doesn't appear to be a regression. We believe it's a bug though, so we'll keep this issue open for further investigation.
image

@alex-mechler
Copy link
Contributor

I wonder if this is related to #11910 (which has a pr up)

@francoisl francoisl added Weekly KSv2 and removed Hourly KSv2 labels Oct 21, 2022
@francoisl
Copy link
Contributor

I'm going to be OOO next and won't have time to look into this one more today, going to put it back in the pool.

@francoisl francoisl removed their assignment Oct 21, 2022
@mountiny mountiny added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2022

Triggered auto assignment to @maddylewis (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Weekly KSv2 labels Oct 24, 2022
@mountiny
Copy link
Contributor

Assigning Autoassigner because bug zero initiative.

I think this was not a bug per se, but we should somehow differentiate between the rooms in LHN.

@alex-mechler Would you be able to provide a summary of the findings from the fireroom? I havent been able to follow the latest there.

@alex-mechler
Copy link
Contributor

Would you be able to provide a summary of the findings from the fireroom? I havent been able to follow the latest there.

@mountiny
Copy link
Contributor

mountiny commented Oct 24, 2022

Unknown Workspace was reproducible in production, so this was not a blocker. This is unexpected though, and should be fixed. Its possible that #11910 is related, but not confirmed.

Oh alright so that makes sense, would you be able to update the issue expected and actual results here so we can use this GH for this problem? I think you even got some reproduction steps and screenshots in the Slack

@mountiny mountiny reopened this Oct 24, 2022
@mountiny
Copy link
Contributor

Lets put this on hold for this #11910 actually as it seems similiar.

@mountiny mountiny changed the title Chat - Two admis and two announce rooms have been created after click Create a Free Policy in OldDot [HOLD App#11910] Chat - Two admis and two announce rooms have been created after click Create a Free Policy in OldDot Oct 24, 2022
@alex-mechler
Copy link
Contributor

If 11910 doesn't solve this, I'll update the OP here!

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 2, 2022
@maddylewis
Copy link
Contributor

waiting for update on this one - #11910

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@alex-mechler
Copy link
Contributor

I was also not able to reproduce this. It looks like #11910 solved the issue, so I'm going to close this one out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants