[CP Staging] Fix hasExpensifyGuidesEmails call #12038

mountiny · 2022-10-20T13:39:48Z

Details

Cannot use this here so removing it, it is called within the ReportUtils file so we cannot use this

Fixed Issues

$ #12037

Tests

Verify that no errors appear in the JS console

Have an account with default room (admin room for example)
Sign in and make sure the app does not crash

For me locally I dont have the room so I have updated the condition temporarily to remove the isDefaultRoom check and the permission just to test the method call is fine and not breaking the App.

QA Steps

Verify that no errors appear in the JS console

Have an account with default room (admin room for example)
Sign in and make sure the app does not crash

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions · 2022-10-20T13:40:27Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Gonals · 2022-10-20T13:51:09Z

src/libs/ReportUtils.js

@@ -941,7 +941,7 @@ function shouldReportBeInOptionList(report, reportIDFromRoute, isInGSDMode, curr
    }

    // Include default rooms unless you're on the default room beta, unless you have an assigned guide


NAB: Kinda weird wording on this comment

Gonals · 2022-10-20T13:54:15Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

danieldoglas

LGTM

mountiny · 2022-10-20T14:03:55Z

I have checked off the PR author checklist as done, however, I have been having troubles running App locally due to some unrelated issues. Alberto tested the change in Android and confirmed it works.

melvin-bot · 2022-10-20T14:07:28Z

@mountiny looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[CP Staging] Fix hasExpensifyGuidesEmails call (cherry picked from commit 5cb3c34)

…-12038 🍒 Cherry pick PR #12038 to staging 🍒

mountiny · 2022-10-20T14:17:48Z

Not an emergency the tests were passing

alex-mechler · 2022-10-20T15:05:30Z

Ah, thanks for fixing this! I should have tested login flow!

OSBotify · 2022-10-20T15:27:00Z

🚀 Cherry-picked to staging by @mountiny in version: 1.2.18-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

mountiny · 2022-10-20T15:29:16Z

@trjExpensify has confirmed the fix worked.

trjExpensify · 2022-10-20T15:29:56Z

Yep, I can access staging NewDot on web again. 👍

OSBotify · 2022-10-24T23:33:13Z

🚀 Deployed to production by @chiragsalian in version: 1.2.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:43:34Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T19:01:19Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove this from the call

e457989

mountiny added the CP Staging label Oct 20, 2022

mountiny requested a review from a team as a code owner October 20, 2022 13:39

mountiny self-assigned this Oct 20, 2022

melvin-bot bot requested review from NikkiWines and Santhosh-Sellavel and removed request for a team October 20, 2022 13:40

Gonals self-requested a review October 20, 2022 13:48

Gonals reviewed Oct 20, 2022

View reviewed changes

mountiny requested a review from Gonals October 20, 2022 14:02

Gonals approved these changes Oct 20, 2022

View reviewed changes

danieldoglas approved these changes Oct 20, 2022

View reviewed changes

mountiny merged commit 5cb3c34 into main Oct 20, 2022

mountiny deleted the vit-fixDeployBlocker branch October 20, 2022 14:07

melvin-bot bot added the Emergency label Oct 20, 2022

OSBotify pushed a commit that referenced this pull request Oct 20, 2022

Merge pull request #12038 from Expensify/vit-fixDeployBlocker

fc79da2

[CP Staging] Fix hasExpensifyGuidesEmails call (cherry picked from commit 5cb3c34)

OSBotify mentioned this pull request Oct 20, 2022

🍒 Cherry pick PR #12038 to staging 🍒 #12040

Merged

OSBotify added a commit that referenced this pull request Oct 20, 2022

Merge pull request #12040 from Expensify/OSBotify-cherry-pick-staging…

fe418b1

…-12038 🍒 Cherry pick PR #12038 to staging 🍒

OSBotify mentioned this pull request Oct 20, 2022

Deploy Checklist: New Expensify 2022-10-19 #11979

Closed

36 tasks

Gonals removed the Emergency label Oct 20, 2022

alex-mechler mentioned this pull request Oct 20, 2022

Web - OldDot transition - App crashed when creating policy in OldDot #12035

Closed

sketchydroide mentioned this pull request Oct 21, 2022

[HOLD App#11910] Chat - Two admis and two announce rooms have been created after click Create a Free Policy in OldDot #12061

Closed

OSBotify mentioned this pull request Oct 25, 2022

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

45 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix hasExpensifyGuidesEmails call #12038

[CP Staging] Fix hasExpensifyGuidesEmails call #12038

mountiny commented Oct 20, 2022 •

edited

Loading

github-actions bot commented Oct 20, 2022

Gonals Oct 20, 2022

Gonals commented Oct 20, 2022 •

edited by mountiny

Loading

danieldoglas left a comment

mountiny commented Oct 20, 2022

melvin-bot bot commented Oct 20, 2022

mountiny commented Oct 20, 2022

alex-mechler commented Oct 20, 2022

OSBotify commented Oct 20, 2022

mountiny commented Oct 20, 2022

trjExpensify commented Oct 20, 2022

OSBotify commented Oct 24, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

		@@ -941,7 +941,7 @@ function shouldReportBeInOptionList(report, reportIDFromRoute, isInGSDMode, curr
		}

		// Include default rooms unless you're on the default room beta, unless you have an assigned guide

[CP Staging] Fix hasExpensifyGuidesEmails call #12038

[CP Staging] Fix hasExpensifyGuidesEmails call #12038

Conversation

mountiny commented Oct 20, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions bot commented Oct 20, 2022

Gonals Oct 20, 2022

Choose a reason for hiding this comment

Gonals commented Oct 20, 2022 • edited by mountiny Loading

danieldoglas left a comment

Choose a reason for hiding this comment

mountiny commented Oct 20, 2022

melvin-bot bot commented Oct 20, 2022

mountiny commented Oct 20, 2022

alex-mechler commented Oct 20, 2022

OSBotify commented Oct 20, 2022

mountiny commented Oct 20, 2022

trjExpensify commented Oct 20, 2022

OSBotify commented Oct 24, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

mountiny commented Oct 20, 2022 •

edited

Loading

Gonals commented Oct 20, 2022 •

edited by mountiny

Loading