Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - OldDot transition - App crashed when creating policy in OldDot #12035

Closed
kbecciv opened this issue Oct 20, 2022 · 5 comments
Closed

Web - OldDot transition - App crashed when creating policy in OldDot #12035

kbecciv opened this issue Oct 20, 2022 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Oct 20, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12013

Action Performed:

  1. Go to URL https://staging.expensify.com/ and create Control Policy
  2. Go to Setting - Policy - New Policy
  3. Select Free Policy

Expected Result:

NewDot should work fine without crashing

Actual Result:

App crashed in NewDot

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18-3

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1486.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 20, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sketchydroide
Copy link
Contributor

@alex-mechler seems like this was broken with #12013, not sure it was related but QA says that this happened after the CP

@alex-mechler
Copy link
Contributor

@mountiny Already has a fix for this up! #12038

@alex-mechler alex-mechler assigned mountiny and unassigned pecanoro Oct 20, 2022
@mountiny mountiny added the Reviewing Has a PR in review label Oct 20, 2022
@mountiny
Copy link
Contributor

Tom has confirmed the fix worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants